fix(type): theme field autocompletion
#449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vaakian
changed the title
theme field autocompletion
LeoDog896
approved these changes
Mar 28, 2023
| @@ -193,12 +193,14 @@ export interface IShikiTheme extends IRawTheme { | |||
| colors?: Record<string, string> | |||
| } | |||
|
|
|||
| interface Nothing {} | |||
There was a problem hiding this comment.
LGTM! My only suggestion is to document what this utility type is for. Afaik, the reason why this works is that T is the primary completion, while U is provided as a fallback by unionizing it with a type that can never be used but doesn't error out. Otherwise, that is fully optional (seems self-documenting) and the contribution is great!
|
Yeah, looks good to me, nice switch with the interface 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
themefield #448It's suffering without autocompletion when trying to use built-in themes. But I noticed that the code has already attempted to provide it but it stoped working on
TypeScript version >= 4.7.4.I've tested different approaches, here's the playground demo, and finally decided to use the empty interface solution.
Before:
After: