fix(transformers): allow SQL comment syntax in notation transformer, fix #654 #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
changed the title
antfu
approved these changes
Apr 15, 2024
diegohaz
pushed a commit
to ariakit/ariakit
that referenced
this pull request
May 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [shiki](https://togithub.com/shikijs/shiki) ([source](https://togithub.com/shikijs/shiki/tree/HEAD/packages/shiki)) | [`1.3.0` -> `1.5.1`](https://renovatebot.com/diffs/npm/shiki/1.3.0/1.5.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>shikijs/shiki (shiki)</summary> ### [`v1.5.1`](https://togithub.com/shikijs/shiki/releases/tag/v1.5.1) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.5.0...v1.5.1) ##### 🐞 Bug Fixes - **core**: Simplify cloudflare wasm loading - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [shikijs/shiki#670 [<samp>(cd239)</samp>](https://togithub.com/shikijs/shiki/commit/cd239324) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.5.0...v1.5.1) ### [`v1.5.0`](https://togithub.com/shikijs/shiki/releases/tag/v1.5.0) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.4.0...v1.5.0) ##### 🚀 Features - Upgrade deps, new langs - by [@​antfu](https://togithub.com/antfu) [<samp>(d5b04)</samp>](https://togithub.com/shikijs/shiki/commit/d5b04703) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.4.0...v1.5.0) ### [`v1.4.0`](https://togithub.com/shikijs/shiki/releases/tag/v1.4.0) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.3.0...v1.4.0) ##### 🚀 Features - Upgrade deps, new langs and themes - by [@​antfu](https://togithub.com/antfu) [<samp>(26f37)</samp>](https://togithub.com/shikijs/shiki/commit/26f37f08) ##### 🐞 Bug Fixes - **core**: Check existance of `Buffer.isBuffer`, fix [#​664](https://togithub.com/shikijs/shiki/issues/664) - by [@​NullVoxPopuli](https://togithub.com/NullVoxPopuli) in [shikijs/shiki#666 and [shikijs/shiki#664 [<samp>(86d52)</samp>](https://togithub.com/shikijs/shiki/commit/86d5271e) - **monaco**: Options for tokenize limit - by [@​hddhyq](https://togithub.com/hddhyq), [@​antfu](https://togithub.com/antfu) and **Anthony Fu** in [shikijs/shiki#657 [<samp>(a606d)</samp>](https://togithub.com/shikijs/shiki/commit/a606d449) - **transformers**: Allow SQL comment syntax in notation transformer, fix [#​654](https://togithub.com/shikijs/shiki/issues/654) - by [@​senicko](https://togithub.com/senicko) in [shikijs/shiki#655 and [shikijs/shiki#654 [<samp>(cc135)</samp>](https://togithub.com/shikijs/shiki/commit/cc13539e) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.3.0...v1.4.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM0MC4xMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#654)
Description
It was not possible to highlight a line in SQL using
-- [!code highlight].I have added SQL comment notation (
--) to the comment notation transformer.Linked Issues
#654