New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chart.jsを2.9.4から4.4.1に更新 #1148
chart.jsを2.9.4から4.4.1に更新 #1148
Conversation
更新に伴い下記対応を実施した * chart.jsの更新 * v3の設定の構造変更に追従 * @types/chart.jsの更新 * Chart初期化時に必要なモジュールのみをロードするようにした(v4系からの機能) * webpack * color-name, chartjs-color, color-name, moment がchart.jsの依存から消えたため削除 * @kurkle/color がchart.jsの依存に追加されたため追加 * moment の externals の設定を削除
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1148 +/- ##
==========================================
Coverage 41.55% 41.55%
Complexity 980 980
==========================================
Files 121 121
Lines 3598 3598
==========================================
Hits 1495 1495
Misses 2103 2103 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chart.jsに定義ファイルがバンドルされていた
@shibafu528 レビューありがとうございます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
表題の通りchart.jsをv2.9.4からv4.4.1に更新しました。
更新前後で挙動の違いはないようにしたつもりです。
更新に伴い下記対応を実施しました
なお、本PRが取り込まれたらdependabotによる下記PRは閉じてよさそうです。
#1126
参考資料