Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'send on closed channel' bug with windows disks #1430

Merged
merged 1 commit into from Mar 19, 2023
Merged

Fix 'send on closed channel' bug with windows disks #1430

merged 1 commit into from Mar 19, 2023

Conversation

davidnewhall
Copy link
Contributor

@davidnewhall davidnewhall commented Mar 14, 2023 •
edited

Fixes this panic:

goroutine 138166 [running]:
github.com/shirou/gopsutil/v3/disk.PartitionsWithContext.func1()
	github.com/shirou/gopsutil/v3@v3.23.2/disk/disk_windows.go:159 +0x7e7
created by github.com/shirou/gopsutil/v3/disk.PartitionsWithContext
	github.com/shirou/gopsutil/v3@v3.23.2/disk/disk_windows.go:162 +0x1ea

shirou
shirou approved these changes Mar 19, 2023
View reviewed changes
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@shirou shirou merged commit 27c8bfa into shirou:master Mar 19, 2023
@davidnewhall
Copy link
Contributor Author

No, thank you! This package has saved me countless hours. Much appreciated.

@shirou shirou mentioned this pull request Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

Assignees
No one assigned
Labels
package:disk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidnewhall @shirou