Skip to content

Commit

Permalink
Address review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
alcaeus authored and shivammathur committed Feb 19, 2021
1 parent fd62612 commit 3f46698
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions src/extensions.ts
Expand Up @@ -59,15 +59,6 @@ export async function addExtensionDarwin(
// the version may match that as well
case /.*-(.*)\/(.*)@(.*)/.test(extension):
matches = /.*-(.*)\/(.*)@(.*)/.exec(extension) as RegExpExecArray;
if (matches == null) {
// Shouldn't happen
add_script += await utils.getUnsupportedLog(
extension,
version,
'darwin'
);
return;
}
add_script += await utils.joins(
'\nadd_extension_from_github',
ext_name,
Expand Down Expand Up @@ -294,15 +285,6 @@ export async function addExtensionLinux(
// the version may match that as well
case /.*-(.*)\/(.*)@(.*)/.test(extension):
matches = /.*-(.*)\/(.*)@(.*)/.exec(extension) as RegExpExecArray;
if (matches == null) {
// Shouldn't happen
add_script += await utils.getUnsupportedLog(
extension,
version,
'linux'
);
return;
}
add_script += await utils.joins(
'\nadd_extension_from_github',
ext_name,
Expand Down

0 comments on commit 3f46698

Please sign in to comment.