Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sqlsvr 5.11.1 on PHP 8 #766

Merged
merged 1 commit into from Sep 9, 2023

Conversation

GrahamCampbell
Copy link
Contributor


name: 🐞 Bug Fix
about: You found a bug, want to improve something or add a new feature
labels: bug or enhancement


A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions,
so that the development can be pointed in the intended direction.

Related discussion:

Further notes in Contribution Guidelines
Thank you for your contribution.

Description

This PR [briefly explain what it does]

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (321f8d7) 100.00% compared to head (a9a661c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #766   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          589       589           
  Branches        98        98           
=========================================
  Hits           589       589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivammathur
Copy link
Owner

@GrahamCampbell
Thanks for the contribution.

Released 2.26.0. It should now install the latest version.

Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/6181784047/workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants