Add automatic detection of required PHP version from Composer's platform setting #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #754 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 577 589 +12
Branches 92 98 +6
=========================================
+ Hits 577 589 +12
|
shivammathur
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: ⚙ Improvement
about: Supports automatic detection of PHP version from composer.lock or composer.json file
labels: enhancement
This is related to #751 and should help with #629, #713, and #639.
Description
This PR adds detection of the "config.platform.php" setting available in composer.json (which is also saved as platform-overrides.php in composer.lock), so that the required PHP version for an application using Composer will be automatically detected.
As the config.platform.php setting forces Composer to lock dependencies to a specific PHP version, it's a perfect way to detect the "required" version of PHP for a project without any risk of conflicts due to differing versions.
npm run formatbefore the commit.npm run lintbefore the commit.npm run releasebefore the commit.npm testreturns with no unit test errors and all code covered.