Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable shared library and PIC, fixes #1756 #1757

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

shogo82148
Copy link
Owner

@shogo82148 shogo82148 commented Feb 8, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Updated build scripts to enhance library sharing capabilities and fix Perl setup issues.

Copy link

coderabbitai bot commented Feb 8, 2024

Walkthrough

The recent modifications to the build scripts for both Darwin and Linux platforms focus on refining the build process. These enhancements include the exclusion of manual directories from the build, the activation of shared libraries and Position Independent Code (PIC) options, and a fix for a Perl-related configuration issue. This streamlined approach aims to optimize the build environment and address specific setup challenges.

Changes

Files Change Summary
scripts/darwin/build.pl
scripts/linux/build.pl
Updated options to exclude man directories, enable shared libraries and PIC, and fix Perl setup.

🐇✨
In scripts' land, beneath the code,
A rabbit hopped along the road.
"No man pages here," it said,
"Just shared libs and PIC ahead!"
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d36c7e9 and 124e5a1.
Files selected for processing (2)
  • scripts/darwin/build.pl (1 hunks)
  • scripts/linux/build.pl (1 hunks)
Additional comments: 2
scripts/linux/build.pl (1)
  • 113-118: Ensure the -Dcccdlflags=-fPIC and -Duseshrplib options are compatible across all targeted Linux distributions and Perl versions. This is critical for ensuring the build process's portability and stability.
scripts/darwin/build.pl (1)
  • 123-128: Verify the -Dcccdlflags=-fPIC and -Duseshrplib options for compatibility with macOS versions and architectures, especially considering the transition to ARM-based chips. Compatibility is essential for ensuring the build process works seamlessly across different macOS versions and hardware.

@shogo82148 shogo82148 merged commit b758c78 into main Feb 8, 2024
403 of 452 checks passed
@shogo82148 shogo82148 deleted the enable-useshrplib-and-pic-option branch February 8, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant