-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't use deprecated io/ioutil package #43
Conversation
Warning Rate Limit Exceeded@shogo82148 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 40 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThis update focuses on modernizing the codebase by transitioning from the deprecated Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- integration_test.go (2 hunks)
Additional comments: 1
integration_test.go (1)
- 57-58: The update from
ioutil.TempFile
toos.CreateTemp
in thetempMkFile
function aligns with the PR's objectives and modern Go best practices.
|
||
// tempMkdir makes a temporary directory | ||
func tempMkdir(t *testing.T) string { | ||
dir, err := ioutil.TempDir("", "fsnotify") | ||
t.Helper() | ||
dir, err := os.MkdirTemp("", "fsnotify") | ||
if err != nil { | ||
t.Fatalf("failed to create test directory: %s", err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [6-6]
The io/ioutil
package is still imported but appears to be unused after the updates. Consider removing this import to clean up the code and fully align with the PR's objectives of eliminating deprecated package usage.
- "io/ioutil"
Summary by CodeRabbit
os
package for creating temporary directories and files, enhancing compatibility and performance.