Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for finding nested dir at path.basename(cwd) #1

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Add test for finding nested dir at path.basename(cwd) #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a4917a
Addition testing for edge cases
coreyfarrell Apr 21, 2019
306e65e
Tweak variable name
sholladay Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
60 changes: 59 additions & 1 deletion test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ const name = {
packageDirectory: 'find-up',
packageJson: 'package.json',
fixtureDirectory: 'fixture',
modulesDirectory: 'node_modules',
baz: 'baz.js',
qux: 'qux.js'
};

// These paths are relative to the project root
const relative = {
fixtureDirectory: name.fixtureDirectory
fixtureDirectory: name.fixtureDirectory,
modulesDirectory: name.modulesDirectory
};
relative.baz = path.join(relative.fixtureDirectory, name.baz);
relative.qux = path.join(relative.fixtureDirectory, name.qux);
Expand Down Expand Up @@ -188,6 +190,22 @@ test('sync (nested descendant directory)', t => {
t.is(foundPath, absolute.barDir);
});

test('async (nested descendant directory, custom cwd)', async t => {
const filePath = await findUp(relative.barDir, {
cwd: relative.modulesDirectory
});

t.is(filePath, absolute.barDir);
});

test('sync (nested descendant directory, custom cwd)', t => {
const filePath = findUp.sync(relative.barDir, {
cwd: relative.modulesDirectory
});

t.is(filePath, absolute.barDir);
});

test('async (nested cousin directory, custom cwd)', async t => {
const foundPath = await findUp(relative.barDir, {
cwd: relative.fixtureDirectory
Expand Down Expand Up @@ -220,6 +238,46 @@ test('sync (ancestor directory, custom cwd)', t => {
t.is(foundPath, absolute.fixtureDirectory);
});

test('async (absolute directory)', async t => {
const filePath = await findUp(absolute.barDir);

t.is(filePath, absolute.barDir);
});

test('sync (absolute directory)', t => {
const filePath = findUp.sync(absolute.barDir);

t.is(filePath, absolute.barDir);
});

test('async (not found, absolute file)', async t => {
const filePath = await findUp(path.resolve('somenonexistentfile.js'));

t.is(filePath, undefined);
});

test('sync (not found, absolute file)', t => {
const filePath = findUp.sync(path.resolve('somenonexistentfile.js'));

t.is(filePath, undefined);
});

test('async (absolute directory, disjoint cwd)', async t => {
const filePath = await findUp(absolute.barDir, {
cwd: t.context.disjoint
});

t.is(filePath, absolute.barDir);
});

test('sync (absolute directory, disjoint cwd)', t => {
const filePath = findUp.sync(absolute.barDir, {
cwd: t.context.disjoint
});

t.is(filePath, absolute.barDir);
});

test('async (not found)', async t => {
const foundPath = await findUp('somenonexistentfile.js');

Expand Down