Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

chore: update tw intellisense #2186

Merged
merged 1 commit into from
May 15, 2023
Merged

chore: update tw intellisense #2186

merged 1 commit into from
May 15, 2023

Conversation

alantoa
Copy link
Collaborator

@alantoa alantoa commented May 15, 2023

Why

image

image

image

How

Test Plan

@vercel
Copy link

vercel bot commented May 15, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
showtime ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 7:01am

@github-actions
Copy link

PR Preview - Storybook

This pull request preview deployment is now available.

Open Details

✅ Preview: exp+io.showtime.storybook://expo-development-client/?url=https://u.expo.dev/e77d5b68-bb27-45da-aa5c-96c1fdbf6706&channel-name=pr-2186

Comment ID:

@github-actions
Copy link

PR Preview - App

This pull request preview deployment is now available.

Open Details

✅ Preview: exp+io.showtime.development://expo-development-client/?url=https://u.expo.dev/45cbf5d5-24fe-4aa6-9580-acf540651abd&channel-name=pr-2186

Comment ID:

@alantoa alantoa changed the title feat: update tw intellisense chore: update tw intellisense May 15, 2023
hirbod
hirbod reviewed May 15, 2023
View reviewed changes
.vscode/settings.json
@@ -8,13 +8,7 @@
// already have a Prettier plugin, so don't need this.
Copy link
Contributor

@hirbod hirbod May 15, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are not allowed in .json. This could / should actually fail

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, now it's the age of JSON5 and we are using it. This is not a problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work in every env though. But yeah, works in VSCode.

hirbod
hirbod suggested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@hirbod hirbod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but comments should be removed

@hirbod hirbod self-requested a review May 15, 2023 09:43
hirbod
hirbod approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@hirbod hirbod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hirbod
hirbod approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@hirbod hirbod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alantoa alantoa merged commit e8c1bf2 into staging May 15, 2023
11 of 12 checks passed
@alantoa alantoa deleted the update-tw-intellisense branch May 15, 2023 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hirbod hirbod hirbod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alantoa @hirbod