Enable ReactRefreshLogBox-builtins.test.ts, remove loader from import…

… trace (vercel#41645)
shuding · Oct 23, 2022 · 20db42b · 20db42b
1 parent dfbc720
commit 20db42b
Show file tree

Hide file tree

Showing 10 changed files with 83 additions and 3 deletions.
diff --git a/packages/next/build/webpack/plugins/wellknown-errors-plugin/parseNotFoundError.ts b/packages/next/build/webpack/plugins/wellknown-errors-plugin/parseNotFoundError.ts
@@ -85,7 +85,7 @@ export async function getNotFoundError(
         .filter(
           (name) =>
             name &&
-            !/next-(middleware|client-pages|flight-(client|server))-loader\.js/.test(
+            !/next-(middleware|client-pages|flight-(client|server|client-entry))-loader\.js/.test(
               name
             )
         )

diff --git a/test/development/acceptance-app/ReactRefresh.test.ts b/test/development/acceptance-app/ReactRefresh.test.ts
@@ -15,6 +15,10 @@ describe('ReactRefresh app', () => {
   beforeAll(async () => {
     next = await createNext({
       files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
+      dependencies: {
+        react: '0.0.0-experimental-9cdf8a99e-20221018',
+        'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
+      },
       skipStart: true,
     })
   })

diff --git a/test/development/acceptance-app/ReactRefreshLogBox-builtins.test.ts b/test/development/acceptance-app/ReactRefreshLogBox-builtins.test.ts
@@ -4,7 +4,7 @@ import { NextInstance } from 'test/lib/next-modes/base'
 import path from 'path'
 
 // TODO-APP: Investigate snapshot mismatch
-describe.skip('ReactRefreshLogBox app', () => {
+describe('ReactRefreshLogBox app', () => {
   if (process.env.NEXT_TEST_REACT_VERSION === '^17') {
     it('should skip for react v17', () => {})
     return
@@ -15,6 +15,10 @@ describe.skip('ReactRefreshLogBox app', () => {
   beforeAll(async () => {
     next = await createNext({
       files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
+      dependencies: {
+        react: '0.0.0-experimental-9cdf8a99e-20221018',
+        'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
+      },
       skipStart: true,
     })
   })
@@ -109,7 +113,7 @@ describe.skip('ReactRefreshLogBox app', () => {
     await cleanup()
   })
 
-  test('Module not found (missing global CSS)', async () => {
+  test('Module not found missing global CSS', async () => {
     const { session, cleanup } = await sandbox(
       next,
       new Map([

diff --git a/test/development/acceptance-app/ReactRefreshLogBox-scss.test.ts b/test/development/acceptance-app/ReactRefreshLogBox-scss.test.ts
@@ -20,6 +20,8 @@ describe.skip('ReactRefreshLogBox app', () => {
       skipStart: true,
       dependencies: {
         sass: 'latest',
+        react: '0.0.0-experimental-9cdf8a99e-20221018',
+        'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
       },
     })
   })

diff --git a/test/development/acceptance-app/ReactRefreshLogBox.test.ts b/test/development/acceptance-app/ReactRefreshLogBox.test.ts
@@ -16,6 +16,10 @@ describe('ReactRefreshLogBox app', () => {
   beforeAll(async () => {
     next = await createNext({
       files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
+      dependencies: {
+        react: '0.0.0-experimental-9cdf8a99e-20221018',
+        'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
+      },
       skipStart: true,
     })
   })

diff --git a/test/development/acceptance-app/ReactRefreshLogBoxMisc.test.ts b/test/development/acceptance-app/ReactRefreshLogBoxMisc.test.ts
@@ -16,6 +16,10 @@ describe.skip('ReactRefreshLogBox app', () => {
   beforeAll(async () => {
     next = await createNext({
       files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
+      dependencies: {
+        react: '0.0.0-experimental-9cdf8a99e-20221018',
+        'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
+      },
       skipStart: true,
     })
   })

diff --git a/test/development/acceptance-app/ReactRefreshModule.test.ts b/test/development/acceptance-app/ReactRefreshModule.test.ts
@@ -14,6 +14,10 @@ describe('ReactRefreshModule app', () => {
   beforeAll(async () => {
     next = await createNext({
       files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
+      dependencies: {
+        react: '0.0.0-experimental-9cdf8a99e-20221018',
+        'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
+      },
       skipStart: true,
     })
   })

diff --git a/test/development/acceptance-app/ReactRefreshRegression.test.ts b/test/development/acceptance-app/ReactRefreshRegression.test.ts
@@ -20,6 +20,8 @@ describe('ReactRefreshRegression app', () => {
         'styled-components': '5.1.0',
         '@next/mdx': 'canary',
         '@mdx-js/loader': '0.18.0',
+        react: '0.0.0-experimental-9cdf8a99e-20221018',
+        'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
       },
     })
   })

diff --git a/test/development/acceptance-app/ReactRefreshRequire.test.ts b/test/development/acceptance-app/ReactRefreshRequire.test.ts
@@ -10,6 +10,10 @@ describe('ReactRefreshRequire app', () => {
   beforeAll(async () => {
     next = await createNext({
       files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
+      dependencies: {
+        react: '0.0.0-experimental-9cdf8a99e-20221018',
+        'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
+      },
       skipStart: true,
     })
   })

diff --git a/test/development/acceptance-app/__snapshots__/ReactRefreshLogBox-builtins.test.ts.snap b/test/development/acceptance-app/__snapshots__/ReactRefreshLogBox-builtins.test.ts.snap
@@ -0,0 +1,52 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`ReactRefreshLogBox app Module not found 1`] = `
+"./index.js:1:0
+Module not found: Can't resolve 'b'
+> 1 | import Comp from 'b'
+  2 |       export default function Oops() {
+  3 |         return (
+  4 |           <div>
+
+Import trace for requested module:
+./app/page.js
+
+https://nextjs.org/docs/messages/module-not-found"
+`;
+
+exports[`ReactRefreshLogBox app Module not found empty import trace 1`] = `
+"./app/page.js:2:6
+Module not found: Can't resolve 'b'
+  1 | 'use client'
+> 2 |       import Comp from 'b'
+    |      ^
+  3 |       export default function Oops() {
+  4 |         return (
+  5 |           <div>
+
+https://nextjs.org/docs/messages/module-not-found"
+`;
+
+exports[`ReactRefreshLogBox app Module not found missing global CSS 1`] = `
+"./app/page.js:2:10
+Module not found: Can't resolve './non-existent.css'
+  1 | 'use client'
+> 2 |           import './non-existent.css'
+    |          ^
+  3 |         export default function Page(props) {
+  4 |           return <p>index page</p>
+  5 |         }
+
+https://nextjs.org/docs/messages/module-not-found"
+`;
+
+exports[`ReactRefreshLogBox app Node.js builtins 1`] = `
+"./node_modules/my-package/index.js:2:0
+Module not found: Can't resolve 'dns'
+
+Import trace for requested module:
+./index.js
+./app/page.js
+
+https://nextjs.org/docs/messages/module-not-found"
+`;