found some missing passHrefs to a tags, reduce some warnings at DOM l…

…evels (#859) * found some missing passHrefs to a tags, reduce some warnings * add changeset Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
shuding · Oct 4, 2022 · b7f7cf6 · b7f7cf6
1 parent c09f450
commit b7f7cf6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/giant-elephants-sit.md b/.changeset/giant-elephants-sit.md
@@ -0,0 +1,5 @@
+---
+'nextra-theme-blog': patch
+---
+
+add missing `passHref` for `NextLink`
diff --git a/docs/components/card/index.tsx b/docs/components/card/index.tsx
@@ -17,7 +17,7 @@ export function Card({ children, title, icon, image, arrow, href, ...props }) {
 
   if (image) {
     return (
-      <Link href={href}>
+      <Link href={href} passHref>
         <a
           className={cn(
             styles.card,
@@ -44,7 +44,7 @@ export function Card({ children, title, icon, image, arrow, href, ...props }) {
   }
 
   return (
-    <Link href={href}>
+    <Link href={href} passHref>
       <a
         className={cn(
           styles.card,

diff --git a/packages/nextra-theme-blog/src/mdx-theme.tsx b/packages/nextra-theme-blog/src/mdx-theme.tsx
@@ -52,7 +52,7 @@ const A = ({ children, ...props }: ComponentProps<'a'>) => {
     )
   }
   return props.href ? (
-    <Link href={props.href}>
+    <Link href={props.href} passHref>
       <a {...props}>{children}</a>
     </Link>
   ) : (

diff --git a/packages/nextra-theme-blog/src/meta.tsx b/packages/nextra-theme-blog/src/meta.tsx
@@ -12,7 +12,7 @@ export default function Meta(): ReactElement {
   const tags = tag ? split(tag) : []
 
   const tagsEl = tags.map(t => (
-    <Link key={t} href="/tags/[tag]" as={`/tags/${t}`}>
+    <Link key={t} href="/tags/[tag]" as={`/tags/${t}`} passHref>
       <a
         className="
           select-none