Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more social icon #2854

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add more social icon #2854

wants to merge 7 commits into from

Conversation

ikhsangama
Copy link

add more some common social media icon

Copy link

changeset-bot bot commented Apr 27, 2024

⚠️ No Changeset found

Latest commit: d67bd94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 5:29pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 5:29pm

Copy link

vercel bot commented Apr 27, 2024

@ikhsangama is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@Netail
Copy link

Netail commented May 7, 2024

Facebook, Twitter, Whatsapp, Threads in that case maybe too?

@glmn
Copy link

glmn commented May 13, 2024

Telegram 🙏

@ikhsangama
Copy link
Author

Facebook, Twitter, Whatsapp, Threads in that case maybe too?

@Netail isn't Twitter icon already reserved here as 'X'? Do we need legacy logo?

@Netail
Copy link

Netail commented May 15, 2024

Facebook, Twitter, Whatsapp, Threads in that case maybe too?

@Netail isn't Twitter icon already reserved here as 'X'? Do we need legacy logo?

Woops, you're right hahaha. Still not used to it being called X now

@Netail
Copy link

Netail commented May 15, 2024

Terima kasih 🙏

@ikhsangama
Copy link
Author

image

@Netail
Copy link

Netail commented May 15, 2024

image

Wait isn't that x just a close icon instead of the x (formally twitter) logo

@ikhsangama
Copy link
Author

whoops hahaha just realize the logo is different, will revert and add new one with "XSocialIcon" or "XTwitterIcon" which naming is better? Open for better naming suggestion

@ikhsangama
Copy link
Author

Updated!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants