Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setHeaders in Query & Mutation #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support setHeaders in Query & Mutation #39

wants to merge 1 commit into from

Conversation

sateeshpnv
Copy link

No description provided.

@aerostitch
Copy link

Hi!

I'm working on writing a client for https://the.slab.com/public/slab-api-vk0o0i33 and the support for headers would really be needed for that.

But I was wondering if it wouldn't be easier to export the http request object inside the Client struct which would allow people to customize the request configuration before executing the Query call.
This would avoid having to add each http parameters that could ever be useful to Query and Mutate and wouldn't change the functions signatures.

Something like aerostitch@83c51de

What do you think?

@dmitshur any opinion on this? Would it be too ugly to expose the http request struct?

Thanks,
Joseph

grihabor pushed a commit to grihabor/graphql that referenced this pull request Jul 20, 2022
@hgiasac
fix subscription hanging on error and add a stop subscription option …
7e9cc29 
…inside the callback (shurcooL#39)

* fix the deadlock issue that the subscription client can't receive error events from the channel.
* close the connection when there is no running subscription
* add a particular error that stops the subscription inside the callback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sateeshpnv @aerostitch