Exit script with error even if token is provided #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverviljamaa
approved these changes
Nov 21, 2018
|
@siddharthkp Have you considered this PR? |
kefranabg
approved these changes
Apr 12, 2019
|
Some news on this PR ? bundlesize cannot be used on CI process without this feature 😕 |
tbetous
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
bundlesizefails a check, exit with status code of1.Motivation and Context
In certain CIs, the exit status is used to indicate whether the build succeeded or failed. Currently, if a CI token is provided, the build exits with
0status code always (even if the check failed) hence some CIs will always markbundlesizebuilds as successful.Types of changes
Previously passing builds in CIs will now fail if
bundlesizecheck fails.Checklist: