Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open-Mode to extends the possibilities of usages #254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
#!/usr/bin/env node

const { inspect } = require('util')
const files = require('./src/files')
const { files, enabledOpenMode } = require('./src/files')
const reporter = require('./src/reporter')
const build = require('./src/build')

reporter(files)
reporter(files, enabledOpenMode)

process.on('unhandledRejection', function(reason) {
console.log('Unhandled Promise')
Expand Down
9 changes: 4 additions & 5 deletions src/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,10 @@ const packageJSONconfig = pkg.bundlesize

program
.option('-f, --files [files]', 'files to test against (dist/*.js)')
.option('-o, --open', 'Allow to run in open mode')
.option('-s, --max-size [maxSize]', 'maximum size threshold (3Kb)')
.option('--debug', 'run in debug mode')
.option(
'-c, --compression [compression]',
'specify which compression algorithm to use'
)
.option('-c, --compression [compression]', 'specify which compression algorithm to use')
.parse(process.argv)

let cliConfig
Expand All @@ -27,7 +25,8 @@ if (program.files) {
{
path: program.files,
maxSize: program.maxSize,
compression: program.compression || 'gzip'
compression: program.compression || 'gzip',
...(program.open && { openMode: true })
}
]
}
Expand Down
4 changes: 3 additions & 1 deletion src/files.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const config = require('./config')
const debug = require('./debug')
const compressedSize = require('./compressed-size')
const files = []
let enabledOpenMode = false

config.map(file => {
const paths = glob.sync(file.path)
Expand All @@ -18,11 +19,12 @@ config.map(file => {
const maxSize = bytes(file.maxSize) || Infinity
const compression = file.compression || 'gzip'
const size = compressedSize(fs.readFileSync(path, 'utf8'), compression)
enabledOpenMode = !!file.openMode
files.push({ maxSize, path, size, compression })
})
}
})

debug('files', files)

module.exports = files
module.exports = { files, enabledOpenMode }
5 changes: 4 additions & 1 deletion src/reporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,11 @@ const compare = (files, masterValues = {}) => {
report({ files, globalMessage, fail })
}

const reporter = files => {
const getTotalSize = files => console.log(files.reduce((acc, file) => acc + file.size, 0))

const reporter = (files, enabledOpenMode) => {
if (api.enabled) api.get().then(masterValues => compare(files, masterValues))
else if (enabledOpenMode) getTotalSize(files)
else compare(files)
}

Expand Down