feat/add pinia store #51

MaloLebrin · 2022-09-22T08:31:42Z

Closes #45

Checklist:

issue number linked above after pound (#)
- replace "Closes " with "Contributes to" or other if this PR does not close the issue
issue checkboxes are all addressed
manually checked my feature / not applicable
wrote tests / not applicable
attached screenshots / not applicable

zoey-kaiser

Thank you so much for your pull request! It means a lot to us to see members of the community take an interest in the development of sidebase!

I am very happy with how you added pina to sidebase so most of my review points are very nit-picky, to add some more polish.
Have a look through my suggestions and feel free to disagree with any points I have made! 😄

Aside from the points I made during the review, I believe we also need to add some points to our documentation before we merge this PR, however we can also take care of writing these (if you don't feel like working on it).

Update ReadMe to include pina in our list of included packages
Write a quick tutorial on how to use pina (maybe also with some more links to help developers if they run into any issues)
Update texts on sidebase website (this is for us 😆)

store/exempleStore.ts

pages/index.vue

store/exempleStore.ts

pages/index.vue

zoey-kaiser · 2022-09-22T13:51:43Z

While doing some more testing I ran into a severe issue. When using the store in historie I get the following error:

Error while collecting story /sidebase/components/example/Status.story.vue:
TypeError [ERR_PACKAGE_IMPORT_NOT_DEFINED]: Package import specifier "#imports" is not defined in package /sidebase/node_modules/@pinia/nuxt/package.json imported from /sidebase/node_modules/@pinia/nuxt/dist/runtime/composables.mjs
    at new NodeError (node:internal/errors:371:5)
    at throwImportNotDefined (node:internal/modules/esm/resolve:442:9)
    at packageImportsResolve (node:internal/modules/esm/resolve:819:3)
    at moduleResolve (node:internal/modules/esm/resolve:973:21)
    at defaultResolve (node:internal/modules/esm/resolve:1080:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:530:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:251:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:79:40)
    at link (node:internal/modules/esm/module_job:78:36)

Have you looked into how to correctly integrate pina into historie?

add exemple how to se Pinia and link to the doc

MaloLebrin · 2022-09-22T15:52:35Z

While doing some more testing I ran into a severe issue. When using the store in historie I get the following error:

Error while collecting story /sidebase/components/example/Status.story.vue:
TypeError [ERR_PACKAGE_IMPORT_NOT_DEFINED]: Package import specifier "#imports" is not defined in package /sidebase/node_modules/@pinia/nuxt/package.json imported from /sidebase/node_modules/@pinia/nuxt/dist/runtime/composables.mjs
    at new NodeError (node:internal/errors:371:5)
    at throwImportNotDefined (node:internal/modules/esm/resolve:442:9)
    at packageImportsResolve (node:internal/modules/esm/resolve:819:3)
    at moduleResolve (node:internal/modules/esm/resolve:973:21)
    at defaultResolve (node:internal/modules/esm/resolve:1080:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:530:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:251:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:79:40)
    at link (node:internal/modules/esm/module_job:78:36)

Have you looked into how to correctly integrate pina into historie?

While doing some more testing I ran into a severe issue. When using the store in historie I get the following error:

Error while collecting story /sidebase/components/example/Status.story.vue:
TypeError [ERR_PACKAGE_IMPORT_NOT_DEFINED]: Package import specifier "#imports" is not defined in package /sidebase/node_modules/@pinia/nuxt/package.json imported from /sidebase/node_modules/@pinia/nuxt/dist/runtime/composables.mjs
    at new NodeError (node:internal/errors:371:5)
    at throwImportNotDefined (node:internal/modules/esm/resolve:442:9)
    at packageImportsResolve (node:internal/modules/esm/resolve:819:3)
    at moduleResolve (node:internal/modules/esm/resolve:973:21)
    at defaultResolve (node:internal/modules/esm/resolve:1080:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:530:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:251:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:79:40)
    at link (node:internal/modules/esm/module_job:78:36)

Have you looked into how to correctly integrate pina into historie?

After some test i think the problem in with pinia in histoire. I didn't use histoire before sorry

zoey-kaiser · 2022-09-22T21:27:33Z

After some test i think the problem in with pinia in histoire. I didn't use histoire before sorry

No problem! I will do some research into it tomorrow and see if I can find any leads. Thank you for the amazing start ❤️

MaloLebrin · 2022-09-23T09:10:40Z

While doing some more testing I ran into a severe issue. When using the store in historie I get the following error:

Error while collecting story /sidebase/components/example/Status.story.vue:
TypeError [ERR_PACKAGE_IMPORT_NOT_DEFINED]: Package import specifier "#imports" is not defined in package /sidebase/node_modules/@pinia/nuxt/package.json imported from /sidebase/node_modules/@pinia/nuxt/dist/runtime/composables.mjs
    at new NodeError (node:internal/errors:371:5)
    at throwImportNotDefined (node:internal/modules/esm/resolve:442:9)
    at packageImportsResolve (node:internal/modules/esm/resolve:819:3)
    at moduleResolve (node:internal/modules/esm/resolve:973:21)
    at defaultResolve (node:internal/modules/esm/resolve:1080:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:530:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:251:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:79:40)
    at link (node:internal/modules/esm/module_job:78:36)

Have you looked into how to correctly integrate pina into historie?

Hi @MaloLebrin! 👋

Thank you so much for your pull request! It means a lot to us to see members of the community take an interest in the development of sidebase!

I am very happy with how you added pina to sidebase so most of my review points are very nit-picky, to add some more polish. Have a look through my suggestions and feel free to disagree with any points I have made! 😄

Aside from the points I made during the review, I believe we also need to add some points to our documentation before we merge this PR, however we can also take care of writing these (if you don't feel like working on it).
* [ ]  Update ReadMe to include `pina` in our list of included packages

* [ ]  Write a quick tutorial on how to use `pina` (maybe also with some more links to help developers if they run into any issues)

* [ ]  Update texts on `sidebase` website (this is for us 😆)

what text are you talking about in third task ?

zoey-kaiser · 2022-09-23T11:37:17Z

what text are you talking about in third task ?

I am referring to the texts on sidebase.io/why, it was a reminder for myself to update the texts once we merged! 😄

zoey-kaiser · 2022-09-23T12:12:50Z

I opened an issue to hopefully get more infos on how to best handle the integration:

histoire-dev/histoire#303

MaloLebrin · 2022-09-28T14:13:28Z

Hello, I think the requested changes are made now, what do you think?

zoey-kaiser · 2022-09-28T14:51:28Z

Hi @MaloLebrin,

I am currently still waiting on update from histoire-dev/histoire#286 to our issue with historie. I will re-review once we get an answer!

zoey-kaiser · 2022-11-15T12:44:57Z

Hi @MaloLebrin!

Sorry for the long delay in this PR. We are currently in the process of removing historie from sidebase, as it is still causing issues with the newer Nuxt versions and other packages such as Pinia (#75)!

I will close this PR for now. If you still want to add pinia you are welcome to do so after we merge #75. Otherwise I would also be willing to create a new PR and add it myself afterwards! Let me know which option you prefer!

Thank you for your PR and request!

MaloLebrin · 2022-11-16T12:12:18Z

I think we shloud rebase from new version after merge #75 and merge this PR ?

zoey-kaiser · 2022-11-16T13:58:14Z

I think we shloud rebase from new version after merge #75 and merge this PR ?

Agreed! Ill reopen this once we did it! We are having some build issues with the newest Nuxt versions and are still trying to figure it out 😢

MaloLebrin · 2022-11-17T12:38:25Z

I think we shloud rebase from new version after merge #75 and merge this PR ?

Agreed! Ill reopen this once we did it! We are having some build issues with the newest Nuxt versions and are still trying to figure it out 😢

Yes of course we are a lot to have this kind of issues

MaloLebrin added 2 commits September 22, 2022 09:48

feat: add pinia to projet with exemple

d7d1330

feat: add auto imports for stores

42d8fec

zoey-kaiser requested changes Sep 22, 2022

View reviewed changes

store/exempleStore.ts Show resolved Hide resolved

pages/index.vue Outdated Show resolved Hide resolved

store/exempleStore.ts Outdated Show resolved Hide resolved

pages/index.vue Show resolved Hide resolved

fix: review changes

75e000a

add exemple how to se Pinia and link to the doc

zoey-kaiser mentioned this pull request Sep 23, 2022

Using historie with Pinia histoire-dev/histoire#303

Closed

MaloLebrin requested a review from zoey-kaiser September 25, 2022 17:48

BracketJohn changed the title ~~Feat/add pinia store~~ feat/add pinia store Sep 26, 2022

zoey-kaiser mentioned this pull request Sep 28, 2022

Error with Nuxt v3.0.0-rc.9: Package import specifier "#build/app.config.mjs" is not defined in package histoire-dev/histoire#286

Closed

6 tasks

Merge branch 'main' into feat/add-pinia-store

4f6d6ce

zoey-kaiser closed this Nov 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/add pinia store #51

feat/add pinia store #51

MaloLebrin commented Sep 22, 2022 •

edited by zoey-kaiser

zoey-kaiser left a comment

zoey-kaiser commented Sep 22, 2022

MaloLebrin commented Sep 22, 2022 •

edited

zoey-kaiser commented Sep 22, 2022

MaloLebrin commented Sep 23, 2022

zoey-kaiser commented Sep 23, 2022

zoey-kaiser commented Sep 23, 2022

MaloLebrin commented Sep 28, 2022

zoey-kaiser commented Sep 28, 2022

zoey-kaiser commented Nov 15, 2022

MaloLebrin commented Nov 16, 2022

zoey-kaiser commented Nov 16, 2022

MaloLebrin commented Nov 17, 2022

feat/add pinia store #51

feat/add pinia store #51

Conversation

MaloLebrin commented Sep 22, 2022 • edited by zoey-kaiser

zoey-kaiser left a comment

Choose a reason for hiding this comment

zoey-kaiser commented Sep 22, 2022

MaloLebrin commented Sep 22, 2022 • edited

zoey-kaiser commented Sep 22, 2022

MaloLebrin commented Sep 23, 2022

zoey-kaiser commented Sep 23, 2022

zoey-kaiser commented Sep 23, 2022

MaloLebrin commented Sep 28, 2022

zoey-kaiser commented Sep 28, 2022

zoey-kaiser commented Nov 15, 2022

MaloLebrin commented Nov 16, 2022

zoey-kaiser commented Nov 16, 2022

MaloLebrin commented Nov 17, 2022

MaloLebrin commented Sep 22, 2022 •

edited by zoey-kaiser

MaloLebrin commented Sep 22, 2022 •

edited