-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Activity support added #217
base: master
Are you sure you want to change the base?
Live Activity support added #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 馃憤
Hey @ozamanav I started playing around with your fork, and noticed that the timestamps are |
// SetDismissalDate sets the aps dismissal-date on the payload. | ||
// This will end live activity on dismissal date timestamp. | ||
// | ||
// {"aps":{"dismissal-date": DismissalDate }}` | ||
func (p *Payload) SetEvent(event ELiveActivityEvent) *Payload { | ||
p.aps().Event = event | ||
return p | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the doc string is still wrong here, something like this maybe?
// SetDismissalDate sets the aps dismissal-date on the payload. | |
// This will end live activity on dismissal date timestamp. | |
// | |
// {"aps":{"dismissal-date": DismissalDate }}` | |
func (p *Payload) SetEvent(event ELiveActivityEvent) *Payload { | |
p.aps().Event = event | |
return p | |
} | |
// SetEvent sets the aps event type on the payload. | |
// This can either be `LiveActivityEventUpdate` or `LiveActivityEventEnd` | |
// | |
// {"aps":{"event": Event }}` | |
func (p *Payload) SetEvent(event ELiveActivityEvent) *Payload { | |
p.aps().Event = event | |
return p | |
} |
FYI I've submitted #219 based on this PR |
Changes
Let me know if you guys have any questions 馃槃