fix: createPool promise as PromisePool (#2060)

sidorares · Jun 12, 2023 · ff3c36c · ff3c36c
1 parent 1a9972d
commit ff3c36c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/test/tsc-build/mysql/createPool/promise/promise.ts b/test/tsc-build/mysql/createPool/promise/promise.ts
@@ -0,0 +1,16 @@
+import { mysql, mysqlp } from '../../../index';
+import { access } from '../../baseConnection';
+
+(async () => {
+   let pool: mysql.Pool | null = null;
+   let promisePool: mysqlp.Pool | null = null;
+   let conn: mysqlp.PoolConnection | null = null;
+
+   if (pool === null) return;
+
+   pool = mysql.createPool(access);
+   promisePool = pool.promise();
+   conn = await promisePool.getConnection();
+
+   conn.release();
+})();
diff --git a/typings/mysql/lib/Pool.d.ts b/typings/mysql/lib/Pool.d.ts
@@ -4,7 +4,7 @@ import {OkPacket, RowDataPacket, FieldPacket, ResultSetHeader} from './protocol/
 import Connection = require('./Connection');
 import PoolConnection = require('./PoolConnection');
 import {EventEmitter} from 'events';
-import {PoolConnection as PromisePoolConnection} from '../../../promise';
+import {Pool as PromisePool} from '../../../promise';
 
 declare namespace Pool {
 
@@ -78,7 +78,7 @@ declare class Pool extends EventEmitter {
     on(event: string, listener: Function): this;
     on(event: 'connection', listener: (connection: PoolConnection) => any): this;
 
-    promise(promiseImpl?: PromiseConstructor): PromisePoolConnection;
+    promise(promiseImpl?: PromiseConstructor): PromisePool;
 }
 
 export = Pool;