This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Reduce package bundle size #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me first check if we can get rid of the bundled dependency, I need to find out why it was added in the first place. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unpacked bundle for
@1.0.0-beta.2is ~12.5 MB.This PR uses rollup to reduce bundle size to ~3.8 MB (the three options,
esm,umdandcjsare all slightly different).3.8 MB is probably still too big for production use, but this is just a first pass and there are likely more minification opportunities, both for this repo and its main dependency,
signalfx.Related issue: #23