Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #498 support IME with input hint along #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AmosJin
Copy link

@AmosJin AmosJin commented Jun 4, 2021

Fixes #498

What did you change (functionally and technically)? functionally

@vercel
Copy link

vercel bot commented Jun 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/signavio/react-mentions/CdG6DPXeS9eSF92EqMgv92z5H9PX
✅ Preview: https://react-mentions-git-fork-amosjin-fix-ime-with-input-hint-136c4d.vercel.app

@codecov-commenter
Copy link

Codecov Report

Merging #499 (e60ad0c) into master (a2c8856) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   78.84%   79.14%   +0.29%     
==========================================
  Files          32       32              
  Lines         695      700       +5     
  Branches      108      109       +1     
==========================================
+ Hits          548      554       +6     
+ Misses        146      145       -1     
  Partials        1        1              
Impacted Files Coverage Δ
src/utils/applyChangeToValue.js 91.89% <100.00%> (+4.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c8856...e60ad0c. Read the comment docs.

@tachibanayu24
Copy link
Contributor

I too was faced with a problem that was solved by this PR.
Thank you for resolving this issue.

In my project, I applied this PR as a patch a few months ago and it has been working fine all along.
So I don’t think it will be a problem to release this PR.

@ghost
Copy link

ghost commented Nov 22, 2022

@tachibanayu24
Could you tell me your workaround of this problem, I don't think I can solve this unless this PR merges.

@tachibanayu24
Copy link
Contributor

@manato-kawamura
Check out the library patch-package.
You can apply arbitrary patch fixes to dependencies.

@ghost
Copy link

ghost commented Nov 22, 2022

@tachibanayu24
Thank you so much for your immediate reply and will try that one.

@jesraygarciano
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IME with input hint along with the cursor can't input
4 participants