bump sigstore-protobuf-specs #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
jku
approved these changes
May 13, 2024
| @@ -217,7 +216,7 @@ def _sign(key: ec.EllipticCurvePrivateKey, stmt: Statement) -> Envelope: | |||
| _Envelope( | |||
| payload=stmt._contents, | |||
| payload_type=Envelope._TYPE, | |||
| signatures=[Signature(sig=signature, keyid=None)], | |||
| signatures=[Signature(sig=signature)], | |||
There was a problem hiding this comment.
How does this work if keyid is not marked optional in the protobuf -- am I missing something?
Closed
From looking at the proto definition, the keyid field is entirely optional. But the code generator isn't smart enough to understand that optional means that the kwarg is also nullable, so I just removed it outright instead of explicitly setting it to TL;DR: The generated message is completely unchanged, we're just correctly handling an overly strict type hint now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps us to
~= 0.3.2. This patch release enables type hinting, allowing us to refine the types a bit here.