Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep 2.0.0 #778

Merged
merged 3 commits into from Sep 28, 2023
Merged

Prep 2.0.0 #778

merged 3 commits into from Sep 28, 2023

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Sep 26, 2023 •
edited

Draft until we're ready to merge this.

@woodruffw
sigstore: 2.0.0
a9fa432 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
README, CHANGELOG: 2.0 prep
12b17ba 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw requested a review from di September 26, 2023 15:36
@woodruffw woodruffw self-assigned this Sep 26, 2023
@woodruffw
transparency: fix Pydantic API use
6cef9ac 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw marked this pull request as ready for review September 26, 2023 22:02
@woodruffw woodruffw requested a review from jku September 26, 2023 22:02
@woodruffw
Copy link
Member Author

This should be safe to merge whenever; we can create the release anytime after it's merged.

jku
jku approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For reference on that pydantic issue

  • I believe FieldValidationInfo still works but the way they marked it deprecated (which seems to be what happened last friday) is what mypy flags as suspicious
  • the fix here looks right to me

@woodruffw woodruffw enabled auto-merge (squash) September 28, 2023 18:24
@woodruffw woodruffw merged commit 6c7069e into main Sep 28, 2023
21 checks passed
@woodruffw woodruffw deleted the ww/release branch September 28, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jku jku jku approved these changes

@di di di approved these changes

Assignees

@woodruffw woodruffw

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woodruffw @jku @di