Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated sigstore/sigstore KMS clients with HashFunc method #517

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

malancas
Copy link
Contributor

Summary

Release Note

Documentation

Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (72f8454) 52.85% compared to head (124ac71) 53.05%.
Report is 8 commits behind head on main.

❗ Current head 124ac71 differs from pull request most recent head 011e9ee. Consider uploading reports for the commit 011e9ee to get more accurate results

Files Patch % Lines
pkg/signer/tink.go 68.96% 9 Missing ⚠️
pkg/signer/signer.go 37.50% 5 Missing ⚠️
pkg/signer/file.go 60.00% 2 Missing ⚠️
pkg/signer/memory.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   52.85%   53.05%   +0.19%     
==========================================
  Files          20       20              
  Lines        1209     1229      +20     
==========================================
+ Hits          639      652      +13     
- Misses        509      516       +7     
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
@malancas malancas changed the title Use updated KMS clients Use updated sigstore/sigstore KMS clients with HashFunc method Dec 4, 2023
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant