fix: simplify implementation, add comment as requested and remove "on…

…ly" from "it.only"

Fixes lint-staged#570

src/runAll.js

@@ -54,21 +54,24 @@ module.exports = function runAll(config) {
           return `No staged files match ${task.pattern}`
         }
         return false
-      },
-      hasStagedFiles: () => task.fileList.length > 0
+      }
     }))
 
     const listrBaseOptions = {
       dateFormat: false,
       renderer
     }
 
-    let hasStagedTaskFiles = false
+    // If all of the configured "linters" should be skipped
+    // avoid executing any "stashing changes..." logic
+    let isSkippingAllLinters = true
     tasks.forEach(task => {
-      hasStagedTaskFiles = hasStagedTaskFiles || task.hasStagedFiles()
+      if (!task.skip()) {
+        isSkippingAllLinters = false
+      }
     })
 
-    if (hasStagedTaskFiles) {
+    if (!isSkippingAllLinters) {
       // Do not terminate main Listr process on SIGINT
       process.on('SIGINT', () => {})
 

test/runAll.spec.js

@@ -162,7 +162,7 @@ describe('runAll', () => {
     }
   })
 
-  it.only('should skip stashing changes if no lint-staged files are changed', async () => {
+  it('should skip stashing changes if no lint-staged files are changed', async () => {
     expect.assertions(4)
     hasPartiallyStagedFiles.mockImplementationOnce(() => Promise.resolve(true))
     sgfMock.mockImplementationOnce((params, callback) => {