Use single cache for both pnpm store and Cypress binaries in CI #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Dec 12, 2022
| path: ~/.cache/Cypress | ||
| key: cypress-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }} | ||
| path: | | ||
| ~/setup-pnpm/node_modules/.bin/store |
There was a problem hiding this comment.
The path is hardcoded for now, as I don't want to add an extra step just to run pnpm store path. I've suggested storing the path as an output of the pnpm/action-setup step in pnpm/action-setup#68 (comment). To be continued.
There was a problem hiding this comment.
Yeah, it is fine like this, no worries.
loichuder
approved these changes
Dec 12, 2022
| path: ~/.cache/Cypress | ||
| key: cypress-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }} | ||
| path: | | ||
| ~/setup-pnpm/node_modules/.bin/store |
There was a problem hiding this comment.
Yeah, it is fine like this, no worries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/setup-nodedoes not and will not provide a way to pass additional paths to its internalactions/cacheinstance, so I move caching into a separate step that takes care of caching both the pnpm store and Cypress binaries.