Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coverage ignore for generated files #2830

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Ragueel
Copy link

@Ragueel Ragueel commented Jan 10, 2024

With these changes, generated files will always be ignored when running tests with coverage.

@simolus3
Copy link
Owner

Thanks for the contribution! However, I don't think we should always opt generated files out of test coverage - maybe some people do want to know how much of their generated code is involved in tests. Making this optional with a builder option would be preferable IMO, but then there is the option from source_gen already so I'm not sure whether this is necessary.

@neiljaywarner
Copy link

@simolus3 shoudl this be closed so new people to the project don't see it as an orange flag?
@Ragueel
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants