Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcemaps & emulator debugging support #166

Closed
wants to merge 2 commits into from

Conversation

ciriousjoker
Copy link

  • Generate sourcemaps so the debugger can find the .ts files
  • Enable --inspect-functions so

Caveat

  1. Debugger disconnects when saving files (because everything recompiles & emulators seem to restart).
  2. I didn't test this yet, I just added the flags where it made sense (adding them works in a real project though)
  3. I wrote no documentation for this for now

@simondotm
Copy link
Owner

simondotm commented Nov 6, 2023

This PR looks good, thanks for the contribution.

I've opened some discussion for this feature here: #165 (comment)

I'm going to hold this PR here for now, while I plan out what is needed in the next release, and if this feature can be included with all of the above.

@ciriousjoker
Copy link
Author

I have no clue how to add the remaining stuff like e2e tests and schema migrations

@dzivoing
Copy link

Has this been merged ? I am trying to debug functions with no success

@simondotm
Copy link
Owner

simondotm commented Apr 6, 2024

I've moved tests around so I'll resolve the conflict/merge from master.

UPDATE: cant merge this as-is, because it is a commit to main branch. I'll try and re-target to a feature branch.

@simondotm simondotm changed the base branch from main to 165-feature-request-support-breakpoints-on-cloud-function-emulators April 6, 2024 11:47
@simondotm simondotm changed the base branch from 165-feature-request-support-breakpoints-on-cloud-function-emulators to main April 6, 2024 11:50
@simondotm
Copy link
Owner

simondotm commented Apr 6, 2024

@ciriousjoker I would like to merge your PR, but because it is merging commits directly to main I cannot accept it.

If you could please sync your fork with the latest from my repo, then re-create your changes on a separate PR branch on your fork and re-submit the PR I'll merge it, and you will keep the contribution credit for this change.

Alternatively, just let me know if you are busy, and I will make the changes here myself.

Thanks

@ciriousjoker
Copy link
Author

@simondotm there you go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants