fix asterisk emphasis rendering by upgrading marked library #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marked v1.1.1 has a problem in rendering emphasis with asterisks (see markedjs/marked#1754). For example, echo "*A pigeon*: a type of *bird*" | md-to-pdf --as-html renders as <body class=""> <p><em>A pigeon</em>: a type of <em>bird</em></p> </body></html> instead of the expected: <body class=""> <p><em>A pigeon*: a type of *bird</em></p> </body></html> Version 1.1.2 resolves this issue (see markedjs/marked#1754 (comment)).
|
Thanks however I'd rather update to the latest version (1.2.3) which I've already done, plus I've also updated all the other dependencies 🤓 Thanks for the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marked v1.1.1 has a problem in rendering emphasis with asterisks (see
markedjs/marked#1754).
For example,
renders as
instead of the expected:
Version 1.1.2 resolves this issue (see
markedjs/marked#1754 (comment)).