Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mock function to overrides non-configurable props #101

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

buschtoens
Copy link
Contributor

@buschtoens buschtoens commented Mar 28, 2019

Based on #100. Fixes #99.

I don't know, if mock is the best name. Maybe override? I don't know. πŸ€·β€β™€οΈ πŸ˜„

@VincentMolinie
Copy link

Can someone review this πŸ™ ?

@boydkr
Copy link

boydkr commented Jan 26, 2021

I could very much use this PR. I'm stuck on 0.6.0 until there's some way to mock onbeforeunload

@AndreJoaquim
Copy link

Hey @simonihmig! I know you probably have more important things to do πŸ˜… But is there any chance we could get this PR merged? It'd be very helpful πŸ™πŸ» Thanks in advance for all your work!

@simonihmig
Copy link
Owner

Hey folks, so the thing here is that this is based (contains those commits) on #100, which had some longer discussions a (even longer) while ago, and which seems to not have been finalized.

I am really not aware anymore of the exact state of those PRs, would need some time to dig into it again. AFAIR the work in #100 is technically required before we can land this, right?

@buschtoens what about you, are you still interested in working on these? Somehow the momentum was interrupted at some point unfortunately, and the PRs became dormant. Not intending to blame anyone here, not having the time to continue work would be totally understandable, just want to figure out if/how we can move this forward!

@simonihmig
Copy link
Owner

I'm stuck on 0.6.0 until there's some way to mock onbeforeunload

Sorry @boydkr for the late reply. Could you explain why you need this PR to mock onbeforeunload. It is a writeable prop after all, right? So that should work, unless I am missing something. In case there is an issue, but it is unrelated to this PR here - which is about overriding non-configurable, non-writable properties AFAIU - then please file a separate issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window.document cannot be mocked / replaced
5 participants