Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use predefined schema for all validation checks (new ajv version as well) #55

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

w473
Copy link

@w473 w473 commented Jan 11, 2021

No description provided.

@simonplend
Copy link
Owner

Hi @w473 👋 I'm the new maintainer of this project.

Thank you so much for your contribution! This looks like a really nice feature addition.

I'm currently working on the v2.2.0 release, but I'm intending to upgrade Ajv to v7 in a v3.0.0 release. In regard to this pull request:

  • I want the upgrade to Ajv v7 to be in its own pull request as its own clear set of changes. When I start working on the v3.0.0 release I will create a pull request which only contains the upgrade to Ajv v7 and references you introducing the upgrade in this pull request (the ajv-formats note you have added in the README is 👍).
  • Once I've merged in the pull request for upgrading to Ajv v7, would you mind creating a new pull request containing only the predefined schema changes?

I think potentially all of the changes you've proposed here could go in the v3.0.0 release, but I would like to separate things out so they can be released separately if needed. It will also make for a cleaner history in git.

@simonplend simonplend added this to the Release v3.0.0 milestone Jan 19, 2021
@w473
Copy link
Author

w473 commented Jan 19, 2021

* would you mind creating a new pull request

sure, no problem. I will then wait for 3.0.0

@simonplend simonplend removed their request for review January 19, 2021 22:03
@simonplend
Copy link
Owner

@w473 Great, thank you 👍

@simonplend simonplend mentioned this pull request Feb 17, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants