Update postcss-bem-linter to v^4.0.0

[andieelmes]

There is a fix in a new version

[simonsmith]

The API to postcss-bem-linter has changed with the postcss 8 update.

I tried the following change:

var bemLinterResult = new Result();
- bemLinter(options)(root, bemLinterResult)
+ bemLinter(options).Once(root, {result: bemLinterResult});
var bemLinterWarnings = bemLinterResult.warnings();

Error is:

TypeError: opts.node.rangeBy is not a function
    at new Warning (/Users/simonsmith/Sites/stylelint-selector-bem-pattern/node_modules/postcss/lib/warning.js:9:29)
    at Result.warn (/Users/simonsmith/Sites/stylelint-selector-bem-pattern/node_modules/postcss/lib/result.js:26:19)
    at /Users/simonsmith/Sites/stylelint-selector-bem-pattern/node_modules/postcss-bem-linter/lib/validate-selectors.js:57:21
    at Array.forEach (<anonymous>)
    at module.exports (/Users/simonsmith/Sites/stylelint-selector-bem-pattern/node_modules/postcss-bem-linter/lib/validate-selectors.js:40:13)
    at checkRule (/Users/simonsmith/Sites/stylelint-selector-bem-pattern/node_modules/postcss-bem-linter/index.js:86:9)
    at /Users/simonsmith/Sites/stylelint-selector-bem-pattern/node_modules/postcss-bem-linter/index.js:53:11
    at Array.forEach (<anonymous>)
    at /Users/simonsmith/Sites/stylelint-selector-bem-pattern/node_modules/postcss-bem-linter/index.js:50:16

I'm not familiar with the changes in postcss 8.

@bjentsch Is there anything obvious here that you could help with? 😄

[bjentsch]

@bjentsch Is there anything obvious here that you could help with? smile

I'll have a look and come back to you ASAP 😘

[andieelmes]

It seems that the error opts.node.rangeBy is not a function should be fixed by using a newer postcss version in the plugin and dependencies stylelint/stylelint#5766

[andieelmes]

But stylelint-test-rule-tape is archived https://github.com/stylelint/stylelint-test-rule-tape and uses an old (6.9.0) stylelint version, which in turn uses an old postcss version (5.0.20)

I thought of just copying stylelint-test-rule-tape code into the project, but it uses old stylelint api createRuleTester https://github.com/stylelint/stylelint-test-rule-tape/blob/master/index.js#L16 that since then has been removed: stylelint/stylelint#4267.

In the removal thread jest-preset-stylelint has been recommended as a replacement: stylelint/stylelint#4267 (comment)

[andieelmes]

Moving to jest-preset-stylelint has been pretty straightforward.

skipBasicChecks has been removed in older jest-preset-stylelint version https://github.com/stylelint/jest-preset-stylelint/blob/main/CHANGELOG.md#500

[simonsmith]

Nice work on this @andieelmes! Thanks

I think you can also remove Node 12 from the CI as it looks like Stylelint dropped support for it

stylelint/stylelint#6311

[simonsmith]

Released - https://www.npmjs.com/package/stylelint-selector-bem-pattern/v/3.0.0

Thanks for the help

[andieelmes]

Thank you!

[bjentsch]

Damn, you guys are fast. Thanks for your work!