Don't install husky in 'postinstall' if '.git' directory doesn't exists #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that this is an edge case, but I found it interesting. If you download the repository using Github UI (
Code
->Download ZIP
), extract the repository and executesnpm install
, next error is raised during the installation:postinstall error
Which means that
husky
needs the.git
directory to exist or will fail. I'm sure that no one would do this, only me on Windows 馃槄, but anyways seems to me that this should be possible because someone could install this only for test it quickly, even if are not planning doing commits.The proposed change seems counterintuitive but is the most straightforward way of do this: if
.git
directory does not exists, exits with 0 code and don't executeshusky install
, otherwise thenode -e
command fails andhusky install
is executed.