Skip to content

Commit

Permalink
Add Alexa ranks to GitHub Templates (#3207)
Browse files Browse the repository at this point in the history
* Add Alexa ranks to GitHub Templates

* Add trailing newline to icon_request.md

* Remove excess space from icon_request.md

* Updates from review

* Remove choice between issue & rank

* Fix typo in issue template

Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>

* Improve wording in issue template and close last comment

Co-authored-by: Lucas Becker <runxel@users.noreply.github.com>
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
  • Loading branch information
3 people committed Jun 22, 2020
1 parent b447c72 commit af4024c
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 9 deletions.
27 changes: 18 additions & 9 deletions .github/ISSUE_TEMPLATE/icon_request.md
Expand Up @@ -4,17 +4,26 @@ about: Request a new icon for SimpleIcons
labels: new icon
---

<!-- Before opening a new issue search for duplicate or closed issues -->
<!--
We won't add non-brand icons or anything related to illegal services.
If in doubt, open an issue and we'll have a look.
Before opening a new issue please search for duplicate or closed
issues or PRs. If you find one for the brand your requesting then
leave a comment on it or add a reaction to the original post.
<!-- When requesting a new icon we need information such as: -->
When requesting a new icon please provide the following information:
-->
**Name:**
**Website:**
**Official resources for icon and color:**
<!-- for example media kits, brand guidelines, SVG files, ...) -->

**Alexa rank:**
<!-- The Alexa rank can be retrieved at https://www.alexa.com/siteinfo/
Please see our contributing guidelines for more details on how we
assess a brand's popularity. -->

<!--
We won't add non-brand icons or anything related to illegal services.
If in doubt open an issue and we'll have a look.
-->
**Official resources for icon and color:**
<!-- for example media kits, brand guidelines, SVG files, etc. -->

<!-- For more details on our processes please see our contributing
guidelines, which can be found at
https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md -->
4 changes: 4 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Expand Up @@ -7,6 +7,10 @@ https://petershaggynoble.github.io/MDI-Sandbox/simpleicons/preview/
-->

**Issue:**
**Alexa rank:**
<!-- The Alexa rank can be retrieved at https://www.alexa.com/siteinfo/
Please see our contributing guidelines for more details on how we
assess a brand's popularity. -->

### Checklist
- [ ] I updated the JSON data in `_data/simple-icons.json`
Expand Down

0 comments on commit af4024c

Please sign in to comment.