Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResearchGate icon update #2884

Closed
greenled opened this issue Apr 1, 2020 · 8 comments · Fixed by #2888
Closed

ResearchGate icon update #2884

greenled opened this issue Apr 1, 2020 · 8 comments · Fixed by #2888
Assignees
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both

Comments

@greenled
Copy link
Contributor

greenled commented Apr 1, 2020

Name: ResearchGate
Website: https://www.researchgate.net/
Official resources for icon and color: Official website's favicon

Alexa rank: 165

I could make a PR with this one.

@greenled greenled added the new icon Issues or pull requests for adding a new icon label Apr 1, 2020
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Apr 1, 2020

Suggested colour: #40ba9b , from website's stylesheet. They also use #00ccbb but as the former is used in their full logo I think that's what we should go with.

We also need to decide whether or not to include the box. They use it without the box themselves in a couple of places (see page 12 of this PDF, for example) so we should be able to do the same. What do the other @simple-icons/maintainers think?

@PeterShaggyNoble PeterShaggyNoble added the good first issue Issues we believe are simple and a good first stab at contributing to the project label Apr 1, 2020
@ericcornelissen
Copy link
Contributor

#40ba9b seems like the best option for the colour. As for the logo, I would expect it with box, but that is just an intuition and not based on anything.

@greenled
Copy link
Contributor Author

greenled commented Apr 1, 2020

In the header (when you are logged in), the .header-logged-in__logo element has an unboxed icon shape in background-image: url("data:image/svg+xml;...") and a background-color of #00ccbb.

@PeterShaggyNoble
Copy link
Member

Good find, @greenled 👍 I think that helps the case of us using the unboxed version. And I'd suggest basing it on that base-64 encoded SVG.

As for the colour, it looks like #40ba9b is only really used on the homepage - the header of every other page uses #00ccbb. Couple that with the logged in logo & the mask-icon link in the HTML source both using that colour too and I change my vote to #00ccbb.

@greenled
Copy link
Contributor Author

greenled commented Apr 1, 2020

I just found out ResearchGate icon IS ALREADY IN Simple Icons 😅. Added by @runxel in #1980 with box and #00ccbb color.

@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Apr 1, 2020

D'oh! That's why the name was familiar! Sorry, I'd assumed you'd already searched the existing icons - my bad.

Before closing this out, though, let's decide whether or not we want to update to the unboxed version.

@PeterShaggyNoble PeterShaggyNoble added duplicate Issues or pull requests that already exist and removed good first issue Issues we believe are simple and a good first stab at contributing to the project labels Apr 1, 2020
@greenled
Copy link
Contributor Author

greenled commented Apr 1, 2020

No, my bad. Nevertheless, I would like to ask you to consider the unboxed version. The LinkedIn and Twitter ReasearGate profiles use the unboxed version.

@PeterShaggyNoble
Copy link
Member

Seeing as the favicon seems to be the only place they use the boxed version, so, I think it's safe enough for us to update to the unboxed if you want to put a PR together.

@PeterShaggyNoble PeterShaggyNoble added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both and removed duplicate Issues or pull requests that already exist new icon Issues or pull requests for adding a new icon labels Apr 1, 2020
@greenled greenled changed the title ResearchGate icon ResearchGate icon update Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants