Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ResearchGate icon with unboxed variant #2888

Merged
merged 1 commit into from Apr 2, 2020
Merged

Update ResearchGate icon with unboxed variant #2888

merged 1 commit into from Apr 2, 2020

Conversation

greenled
Copy link
Contributor

@greenled greenled commented Apr 1, 2020 •
edited

researchgate

Issue: Closes #2884

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Apr 2, 2020
@PeterShaggyNoble
Copy link
Member

Thanks for this one, @greenled 👍

Could you post the complete string for the SVG that you mentioned here so that we can do a comparison without having to create an account, please?

I'd also like to get some feedback from @runxel & @phatbhoy67 on this one, as they worked on the original (see conversation in #2884).

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Apr 2, 2020
runxel
runxel approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point everything seems to be fine! 👍

@greenled
Copy link
Contributor Author

greenled commented Apr 2, 2020

Could you post the complete string for the SVG that you mentioned here so that we can do a comparison without having to create an account, please?

Sure:

.header-logged-in__logo {
	background-image: url("data:image/svg+xml;charset%3DUS-ASCII,%3Csvg%20width%3D%22114%22%20height%3D%22124%22%20viewBox%3D%220%200%20114%20124%22%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%3E%3Cpath%20d%3D%22M76.344%20123.168c2.482%200%205.11-.438%206.716-1.168v-3.796c-5.256%200-10.512-3.65-14.308-7.738-6.424-7.008-15.038-18.25-22.192-30.952%2011.826-2.774%2020.586-13.87%2020.586-24.966%200-16.352-12.702-23.944-29.346-23.944-8.614%200-15.476.438-21.9.438-5.84%200-11.68%200-15.33-.146v4.234l5.548%201.022c3.796.73%205.986%202.482%205.986%2011.534v57.524c0%209.052-2.19%2010.804-5.986%2011.534L.57%20117.766V122c3.942-.146%2010.804-.438%2017.666-.438%206.57%200%2015.038.292%2018.688.438v-4.234l-7.592-1.022c-3.942-.584-5.986-2.482-5.986-11.534V80.828c3.504.292%206.57.292%2011.242.292%208.906%2015.914%2017.374%2027.886%2022.192%2033.434%204.38%205.256%2011.096%208.614%2019.564%208.614zM33.858%2074.55c-4.964%200-7.154-.146-10.512-.438V37.466c3.358-.292%207.884-.292%2011.826-.292%2012.264%200%2019.564%206.424%2019.564%2018.104%200%2011.534-7.884%2019.272-20.878%2019.272zm44.56-36.852A40.494%2040.494%200%200%201%2078.024%2035a45.87%2045.87%200%200%201-.252-3.705%20158.605%20158.605%200%200%201-.072-5.18c0-2.013.024-3.74.072-5.178a45.87%2045.87%200%200%201%20.252-3.705c.12-1.03.25-1.93.395-2.698.14-.767.33-1.51.57-2.23%201.24-3.79%203.31-6.642%206.18-8.56%202.88-1.92%206.4-2.88%2010.57-2.88%202.16%200%204.1.253%205.82.756%201.727.505%203.26%201.2%204.604%202.088a15.286%2015.286%200%200%201%203.46%203.092c.96%201.18%201.75%202.44%202.375%203.78.24.43.167.77-.217%201.01l-5.32%202.2c-.44.24-.77.12-1.01-.36-1.2-2.204-2.21-3.66-3.89-4.712-1.68-1.055-3.24-1.545-5.83-1.545-2.78%200-4.05.55-5.8%201.796-1.75%201.24-3.01%202.79-3.78%205.14-.14.43-.287.96-.43%201.58-.145.62-.25%201.39-.325%202.3a80.63%2080.63%200%200%200-.18%203.34%20134.55%20134.55%200%200%200-.07%204.78c0%201.87.023%203.465.07%204.784.05%201.32.11%202.434.18%203.345.07.91.18%201.68.323%202.303.145.62.29%201.15.43%201.58.77%202.35%201.845%203.63%203.413%204.665%201.564%201.036%203.38%201.8%206.16%201.8%202.493%200%204.774-.71%206.254-1.79%201.48-1.077%202.7-2.5%203.25-4.46.24-.814.56-1.845.75-3.09.19-1.25.187-2.58.187-4.408%200-.29-.144-.433-.43-.433h-8.49c-.48%200-.72-.24-.72-.72v-4.87c0-.48.24-.72.72-.72h15.61c.48%200%20.72.24.72.72V29c0%202.206-.007%204.256-.223%206.15-.213%201.894-.513%203.54-.9%204.74-1.195%203.74-3.09%206.416-5.99%208.406-2.9%201.99-6.65%203.076-10.724%203.076-4.178%200-7.7-.96-10.58-2.878-2.877-1.92-4.94-4.773-6.186-8.56a16.99%2016.99%200%200%201-.575-2.23z%22%20fill%3D%22%23FFF%22%20fill-rule%3D%22evenodd%22%2F%3E%3C%2Fsvg%3E");
}

@PeterShaggyNoble PeterShaggyNoble added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed new icon Issues or pull requests for adding a new icon labels Apr 2, 2020
@PeterShaggyNoble
Copy link
Member

Thanks, @greenled - your path looks spot on to me 👍

@PeterShaggyNoble PeterShaggyNoble merged commit fe7c996 into simple-icons:develop Apr 2, 2020
@ericcornelissen ericcornelissen mentioned this pull request Apr 12, 2020
Merged
ericcornelissen added a commit that referenced this pull request Apr 12, 2020
@ericcornelissen
Release 22 new icons and 5 updated icon (v2.9.0)
84a2e88 
# New icons

- CLiqz (#2858)
- DS Automobiles (#2840)
- Bloglovin (#2834)
- Atari (#2881)
- Qantas (#2839)
- CodersRank (#2876)
- Google Hangouts (#2843)
- PlayStation Vita (#2895)
- Hotels.com (#2894)
- Leaflet (#2868)
- Talend (#2867)
- Air France (#2891)
- Dior (#2903)
- Mozilla Thunderbird (#2906)
- Vultr (#2910)
- CocoaPods (#2905)
- Audacity (#2908)
- pixiv (#2829)
- Jameson (#2808)
- Audioboom (#2882)
- Amazon Fire TV (#2883)
- Apache Druid (#2874)

# Updated icon

- ResearchGate (#2888)
- Adobe Lightroom Classic (#2886)
- Adobe PhoneGap (#2886)
- Adobe Premiere (#2886)
- Adobe XD (#2886)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runxel runxel runxel approved these changes

@phatbhoy67 phatbhoy67 Awaiting requested review from phatbhoy67

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResearchGate icon update
4 participants
@greenled @PeterShaggyNoble @runxel @ericcornelissen