Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fur Affinity icon #2979

Merged
merged 4 commits into from Jun 11, 2020
Merged

Update Fur Affinity icon #2979

merged 4 commits into from Jun 11, 2020

Conversation

KovuTheHusky
Copy link
Contributor

@KovuTheHusky KovuTheHusky commented Apr 25, 2020

Issue: Fur Affinity updated their logo at the end of last year.

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The raster icon was vectorized using Adobe Illustrator's image trace.

@ericcornelissen ericcornelissen added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Apr 25, 2020
@PeterShaggyNoble
Copy link
Member

Thanks for the update, @KovuTheHusky. I'm not too good with comparing raster to vector so I'll leave that to one of the other @simple-icons/maintainers.

However, should the colour not also be updated to one of the greys used on their site?

Also, their favicon is quite different to their logo and would be better suited to our purposes. Having said that, on a quick run through their site, I don't see it in use anywhere else which is usually a case against going that route. If we do decide to then an SVG of that icon can be found at https://github.com/FurAffinity/node-web/blob/2b9e53c334496af7300e74fae3c450a7c74de6dc/public/images/favicon.svg

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Apr 27, 2020
@KovuTheHusky
Copy link
Contributor Author

KovuTheHusky commented Apr 27, 2020

Thanks for the update, @KovuTheHusky. I'm not too good with comparing raster to vector so I'll leave that to one of the other @simple-icons/maintainers.

Understood!

However, should the colour not also be updated to one of the greys used on their site?

I didn't feel confident enough to pick one color myself, though my recommendation would possibly be the deep blue from the scarf in the logo (#36566F) as the website has multiple themes that change the UI colors entirely.

Also, their favicon is quite different to their logo and would be better suited to our purposes. Having said that, on a quick run through their site, I don't see it in use anywhere else which is usually a case against going that route. If we do decide to then an SVG of that icon can be found at https://github.com/FurAffinity/node-web/blob/2b9e53c334496af7300e74fae3c450a7c74de6dc/public/images/favicon.svg

That favicon has been used for years but has never been used elsewhere. The previous icon in simple-icons was also from the header/nav though I understand if there's a preference for the old favicon since it's a simpler shape. It is fairly generic though.

@PeterShaggyNoble
Copy link
Member

the website has multiple themes that change the UI colors entirely.

Would you like to try reaching out to them, see if they have a preference for the colour?

That favicon has been used for years but has never been used elsewhere.

In that case, I'd agree that it wouldn't be the right choice for us - a favicon can occasionally not be an accurate reflection of the branding.

@PeterShaggyNoble
Copy link
Member

Did you have any luck getting feedback from them, @KovuTheHusky? If not then I'd suggest in the absence of anything else to go by then I think we should use one of the colours from their default theme.

@KovuTheHusky
Copy link
Contributor Author

My ticket is still open with no response. ☹️

@PeterShaggyNoble PeterShaggyNoble added in discussion There is an ongoing discussion that should be finished before we can continue and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Jun 9, 2020
@PeterShaggyNoble
Copy link
Member

In that case, let's pick a colour ourselves and update, if necessary, when/if they get back to you. The options that have been presented so far are:

  1. Leave the current colour as-is,
  2. Use one of the greys from the default theme (my vote), and,
  3. The blue from the scarf in the source image (@KovuTheHusky's vote).

What do the other @simple-icons/maintainers think?

@ericcornelissen
Copy link
Contributor

Leaving the color as is definitely incorrect. I would be inclined to agree with @PeterShaggyNoble but given that @KovuTheHusky is most familiar with the brand as well as the remark that:

[...] the website has multiple themes that change the UI colors entirely.

makes me think the suggested blue (#36566F) is perhaps a better choice for now.

@PeterShaggyNoble
Copy link
Member

given that @KovuTheHusky is most familiar with the brand

A fair point 👍

@PeterShaggyNoble
Copy link
Member

As far as my abilities go to compare vector to raster, your path looks pretty spot on to me, @KovuTheHusky so, after the colour is updated, if there are no other objections, I think this can be merged in.

@PeterShaggyNoble PeterShaggyNoble added changes requested and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Jun 11, 2020
@ericcornelissen ericcornelissen merged commit e6f6dbb into simple-icons:develop Jun 11, 2020
@KovuTheHusky KovuTheHusky deleted the furaffinity branch June 11, 2020 18:55
@ericcornelissen
Copy link
Contributor

ericcornelissen commented Jun 11, 2020

Thanks for the update @KovuTheHusky 🎉 Glad we finally merged it.

ericcornelissen added a commit that referenced this pull request Jun 14, 2020
# New Icons

- Canonical (#3184)
- Der Spiegel (#3168)
- DHL (#3048)
- Land Rover (#3195)
- Openlayers (#3165)
- Prime (#3010)
- Quasar (#3144)

# Updated Icons

- Apache ECharts (#3166)
- Apache Pulsar (#3181)
- Fur Affinity (#2979)
- Jupyter (#3170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants