Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Great 2020 Icon Review #3169

Closed
PeterShaggyNoble opened this issue Jun 4, 2020 · 50 comments
Closed

The Great 2020 Icon Review #3169

PeterShaggyNoble opened this issue Jun 4, 2020 · 50 comments
Assignees
@runxel @ericcornelissen @service-paradis @mondeja @fbernhart
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both

Comments

@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Jun 4, 2020 •
edited by adamrusted

As brought to light recently by @davidjb (mostly) and myself, we have quite a number of icons in our library with one or more imperfections from the following list:

  • They do not fit the canvas
  • Their level of precision may be too high
  • They are not perfectly centred on the canvas

It's going to be a fairly hefty job getting all these fixed so we'd like to appeal to the members of our community to help us out if they can by taking on one or more of these icons for review on all 3 points above. (We know, example, that there are 76 icons on the first list that are also not perfectly centred on the canvas.)

To avoid having people working at cross-purposes on the same icons, if you are reviewing one, please either check it off the list or leave a comment. Also, so that this issue doesn't become cluttered with comments, if an icon warrants further discussion, please keep that discussion to the icon's PR, or create an issue for it.

After you fixed an icon, please run SI_UPDATE_IGNORE=true npm run svglint to update the list of icons that is ignored by the SVG linter so that the icon you fixed won't be excluded in the future.

Icons that don't fit the canvas (#3107)

Icons with outlying precision levels (#3120)

Icons that are not centred on the canvas (#3250)

Icons to review checking their simplicity of precision

see #3169 (comment) for details

Icons to remove ineffective segments (#4262)

Avoid negative zeros within paths (#4350)
@PeterShaggyNoble PeterShaggyNoble added help wanted update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both labels Jun 4, 2020
@PeterShaggyNoble PeterShaggyNoble pinned this issue Jun 4, 2020
@NovaGL
Copy link
Contributor

NovaGL commented Jun 5, 2020

Maybe these icons could be grouped into sections, so someone could take one section. Rather than one Icon at a time. Eg Programing, Social, Gaming.

I can understand why that also might not be a good idea. But it seems this will be hard to track in it's current form.

@ericcornelissen
Copy link
Contributor

Maybe these icons could be grouped into sections, so someone could take one section. Rather than one Icon at a time. Eg Programing, Social, Gaming.

I can understand why that also might not be a good idea. But it seems this will be hard to track in it's current form.

If you list the ones you're planning to update in a comment here we can check them off in the original post. Grouping multiple icons into a single PR should not be a problem as the review should be rather quick, since all one need to do is resize the icon.

@ericcornelissen ericcornelissen mentioned this issue Jun 5, 2020
Merged
3 tasks
@PeterShaggyNoble PeterShaggyNoble mentioned this issue Jun 25, 2020
Merged
@PeterShaggyNoble PeterShaggyNoble changed the title Review of icons that don't fit the canvas The Great 2020 Icon review Jul 10, 2020
@PeterShaggyNoble PeterShaggyNoble changed the title The Great 2020 Icon review The Great 2020 Icon Review Jul 10, 2020
This was referenced Jul 10, 2020
Closed
Closed
@mondeja mondeja mentioned this issue Jul 10, 2020
Merged
3 tasks
service-paradis added a commit to service-paradis/simple-icons that referenced this issue Sep 29, 2020
@service-paradis
Update Amazon icon
2f98875 
- simple-icons#3169: The Great 2020 Icon Review
service-paradis added a commit to service-paradis/simple-icons that referenced this issue Sep 29, 2020
@service-paradis
Update Amazon icon
667b7c9 
- simple-icons#3169: The Great 2020 Icon Review
service-paradis added a commit to service-paradis/simple-icons that referenced this issue Sep 29, 2020
@service-paradis
Update Amazon icon
59b9231 
- simple-icons#3169: The Great 2020 Icon Review
service-paradis added a commit to service-paradis/simple-icons that referenced this issue Sep 29, 2020
@service-paradis
Update Amazon icon
a0a4dc8 
- simple-icons#3169: The Great 2020 Icon Review
service-paradis added a commit to service-paradis/simple-icons that referenced this issue Sep 29, 2020
@service-paradis
Update Amazon icon
15c400d 
- simple-icons#3169: The Great 2020 Icon Review
This was referenced Sep 30, 2020
Merged
Merged
Merged
Merged
@service-paradis
Copy link
Member

Just wanted to let you know that I worked on 4 icons:

  1. Amazon icon Correct Amazon icon #3619
  2. Firebase icon Correct Firebase icon #3620
  3. GitLab icon Correct GitLab icon #3621
  4. Firefox Browser Icon Correct Firefox Browser Icon #3622

@runxel
Copy link
Member

runxel commented Oct 1, 2020

Wow, thanks for working on this, @service-paradis! 💯

@service-paradis service-paradis mentioned this issue Oct 1, 2020
Merged
3 tasks
This was referenced Dec 23, 2020
Merged
Merged
@fbernhart fbernhart mentioned this issue Dec 24, 2020
Open
6 tasks
This was referenced Dec 26, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@adamrusted
Copy link
Member

@simple-icons/maintainers I'm unable to access cevo.com at the moment, looks like their site has been down for a few days. Other than that, every icon on this list has been submitted! 🎉

@service-paradis
Copy link
Member

@simple-icons/maintainers I'm unable to access cevo.com at the moment, looks like their site has been down for a few days. Other than that, every icon on this list has been submitted! 🎉

Yeah 🎉
Looks like Cevo website is down from time to time. I though they we're not existing anymore while reviewing icons (#3169 (comment)). Then, it suddenly goes up (#3169 (comment)).

@adamrusted adamrusted mentioned this issue Dec 27, 2020
Merged
@adamrusted
Copy link
Member

And we're done! CEVO website came back online, and I was able to extract the logo. 🎉

@adamrusted adamrusted unpinned this issue Dec 27, 2020
@github-actions github-actions bot removed the tracking label Jan 8, 2021
@PeterShaggyNoble
Copy link
Member Author

Wow! Incredible work, everyone 😁 The last thing I expected to see completed when I came back was this monstrosity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runxel runxel

@ericcornelissen ericcornelissen

@service-paradis service-paradis

@mondeja mondeja

@fbernhart fbernhart

Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@lukeocodes @adamrusted @runxel @ericcornelissen @service-paradis @PeterShaggyNoble @NovaGL @phatbhoy67 @mondeja @fbernhart