You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #2846 being merged since a few releases, I think it is time to consider whether or not the "guidelines" field should be exposed by the NPM package (beyond it being present in the _data/simple-icons.json file).
The main question being - if we decide to include this field - what its value should be if there are no guidelines for a brand. I think we are fine if the field is omitted, but that may be too shortsighted 🙃
The text was updated successfully, but these errors were encountered:
Kind of issue
This issue concerns
Description
With #2846 being merged since a few releases, I think it is time to consider whether or not the
"guidelines"
field should be exposed by the NPM package (beyond it being present in the_data/simple-icons.json
file).That is, in terms of the Node Usage section of the README:
const simpleIcons = require('simple-icons'); console.log(simpleIcons.get('Simple Icons')); /* { title: 'Simple Icons', slug: 'simpleicons', hex: '111111', source: 'https://simpleicons.org/', + guidelines: '[THE GUIDELINES URL]' or ???, svg: '<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg">...</svg>', path: 'M12 12v-1.5c-2.484 ...' } */
The main question being - if we decide to include this field - what its value should be if there are no guidelines for a brand. I think we are fine if the field is omitted, but that may be too shortsighted 🙃
The text was updated successfully, but these errors were encountered: