Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popular icons from unofficial sources #6418

Closed
sachinraja opened this issue Aug 28, 2021 · 11 comments · Fixed by #6428
Closed

Popular icons from unofficial sources #6418

sachinraja opened this issue Aug 28, 2021 · 11 comments · Fixed by #6428
Labels
meta Issues or pull requests regarding the project or repository itself

Comments

@sachinraja
Copy link
Contributor

sachinraja commented Aug 28, 2021

It seems as though there is no official JavaScript icon, which makes sense as there is no official governing body for it. The current source:

"title": "JavaScript",
"hex": "F7DF1E",
"source": "https://github.com/voodootikigod/logo.js",

This uses the source https://github.com/voodootikigod/logo.js, which is unofficial. I realize that it may be too late to remove this icon as I'm sure it is a very popular one, but I thought I'd open this for discussion anyway.

@sachinraja sachinraja added in discussion There is an ongoing discussion that should be finished before we can continue breaking change Issues or pull requests that include a breaking change and scheduled for the next major release labels Aug 28, 2021
@gizmecano
Copy link
Contributor

I understand this appreciation, but however, in this case, it is probable that other icons could be considered in the same case.

For example, Markdown icon has become a de facto standard (notoriously used by Primer Octicons), but it does not seem to me that it is any formal brand (by the way, source in data file refers to the work of the designer, not to the language page).

"title": "Markdown",
"hex": "000000",
"source": "https://github.com/dcurtis/markdown-mark",
"guidelines": "https://github.com/dcurtis/markdown-mark",

@jorgeamadosoria
Copy link
Contributor

I think this one is so established as a de facto standard that it even has other icons styled after it, like Typescript for example.

I feel good keeping it in, even if there is no official source. Javascript certainly is very popular and the icon is well established and necessary for technological lists and such (speaking from experience).
I vote to keep it in, with the current source (after a fashion, see #6399 and it's linked PR).

@sachinraja
Copy link
Contributor Author

sachinraja commented Aug 28, 2021

I disagree that "de facto standard" icons should be included. The contributing guidelines say to "identify official logos and colors."

Icons are supposed to represent a brand, not the community. What do we do if there are two icons actively used by the community? If this icon was announced at JSConf and is used by them (as said in the source), it should be labeled as such. Also note that the JS Wikipedia page does not use the icon.

For example, Markdown icon has become a de facto standard

I guess this issue also raises discussion on those icons.

@sachinraja sachinraja changed the title Should the JavaScript icon be included? Popular icons from unofficial sources Aug 28, 2021
@gizmecano
Copy link
Contributor

As I wrote before, I can understand this opinion: it may sound perhaps rigorous, but reading the current guidelines, it seems founded and logical... 😕

In this vein, in addition to Javascript or Markdown, the icon currently included for CSS3 (added by @ericcornelissen in 2266a14) could probably be added to this specific list. Indeed, this file doesn't seem to exist in the source mentioned in reference: the occurrence of the "CSS3 technology" appears with a dissimilar icon (see below).

w3c css3

@jorgeamadosoria
Copy link
Contributor

jorgeamadosoria commented Aug 28, 2021

I would rather amend the guidelines to include "widely recognized de facto standards" before taking down any of the icons discussed here.
These icons are pivotal in current software development and are very, very accepted as symbols of their respective technologies.
If the community uses two icons, then is up to us to decide which one to add, if there is one that is clearly predominant (in our consensual opinion). If there are no predominant icons (or no consensus) then we can choose not to add any.

But in these cases there is no argument about the icons being representative or widely accepted. The only argument is that they are not official, and that the guidelines preclude this. I don't think that's enough rationale to get rid of such core symbols.

@gizmecano
Copy link
Contributor

Of course, the arguments of @jamesmontemagno are perfectly valid (it is why I mentioned some representations which have become de facto common even if they have no such formal value).

But the comments made by @sachinraja on what appears like a peculiar contradiction currently existing between the acceptance of certain icons and the wording of the guidelines are just the same valid.

It seems there is a dilemma to be resolved.

🤷‍♂️

@jorgeamadosoria
Copy link
Contributor

jorgeamadosoria commented Aug 28, 2021

Ok, the guidelines say that to request an icon:

Is of a popular brand:

  • For websites, the Alexa rank should be less than 500k.
    Note that for brands that have already been added the threshold for continued inclusion rises to 750k.
  • For GitHub projects, the amount of "stars" should be above 5k.
  • For anything else, popularity will be judged on a case-by-case basis.

I'm going to say that this is that third case. We are on the verge of accepting an icon based on eyeballing a chart of Google Trends that "looked similar" to other included icons #6368. And we voted favorably because it looked right to several of us.
I would say that if including these icons looks right to several of us, then we are not violating guidelines as written.

Still, an small amendment would make this clearer, something like "Some icons may be elegible for inclusion by maintainers for particular reasons other than the ones stated, as long as there is consensus" or something of that sort.

Again, better to change the guidelines than to eject these icons.

@sachinraja
Copy link
Contributor Author

sachinraja commented Aug 28, 2021

I have no problem with the popularity of these icons. I only have a problem with their sources, so I agree with @jorgeamadosoria, I think an amendment would help clarify this.

@jorgeamadosoria
Copy link
Contributor

I've added a pull request with tentative text to address this issue in the contributing guidelines. All changes welcome there.
This PR assumes that we are already in agreement with tweaking the guidelines to make Javascript fit. I would suggest making changes to the text in the PR, and further discussion on the issue of changing the guidelines or removing the icons be kept here, if there is any.

@ericcornelissen
Copy link
Contributor

You bring up an interesting issue @sachinraja, and the discussion so far has been excellent. I just want to add three things:

  1. The "brands" discussed so far (CSS, JavaScript, and MarkDown) were all added pretty early in this project's life. So that's the primary reason they don't necessarily obey the current requirements. They've probably not been questions before as, as already pointed out, few people will take issue with their popularity. Of course, that's not to say they shouldn't obey the current requirements.
  2. The "brands" mentioned so far are not the only ones. Other programming languages (notably C, see C Programming Language #1819 and Correct C icon #3868) fall in this category. But really anything that is not really a "brand" (e.g. technologies, standards, etc) can fall in this category unless some kind of governing body took the time to decide on a logo.
  3. I would personally agree that we should keep these kinds of "brands" here and update the contributing guidelines so that they can be included. An alternative would be to double down on the "brands" aspect of this project and remove anything that is not a traditional brand; potentially starting a spin-off project for the removed icons.

@sachinraja
Copy link
Contributor Author

I would personally agree that we should keep these kinds of "brands" here and update the contributing guidelines so that they can be included.

I agree, this makes the most sense to me. Does everyone agree that we should proceed with #6428 then?

@sachinraja sachinraja linked a pull request Aug 29, 2021 that will close this issue
@sachinraja sachinraja removed the breaking change Issues or pull requests that include a breaking change and scheduled for the next major release label Aug 29, 2021
@github-actions github-actions bot removed the in discussion There is an ongoing discussion that should be finished before we can continue label Sep 3, 2021
@ericcornelissen ericcornelissen added the meta Issues or pull requests regarding the project or repository itself label Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants