New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popular icons from unofficial sources #6418
Comments
I understand this appreciation, but however, in this case, it is probable that other icons could be considered in the same case. For example, Markdown icon has become a de facto standard (notoriously used by Primer Octicons), but it does not seem to me that it is any formal brand (by the way, source in data file refers to the work of the designer, not to the language page). simple-icons/_data/simple-icons.json Lines 5437 to 5440 in 198c42d
|
I think this one is so established as a de facto standard that it even has other icons styled after it, like Typescript for example. I feel good keeping it in, even if there is no official source. Javascript certainly is very popular and the icon is well established and necessary for technological lists and such (speaking from experience). |
I disagree that "de facto standard" icons should be included. The contributing guidelines say to "identify official logos and colors." Icons are supposed to represent a brand, not the community. What do we do if there are two icons actively used by the community? If this icon was announced at JSConf and is used by them (as said in the source), it should be labeled as such. Also note that the JS Wikipedia page does not use the icon.
I guess this issue also raises discussion on those icons. |
As I wrote before, I can understand this opinion: it may sound perhaps rigorous, but reading the current guidelines, it seems founded and logical... 😕 In this vein, in addition to Javascript or Markdown, the icon currently included for CSS3 (added by @ericcornelissen in 2266a14) could probably be added to this specific list. Indeed, this file doesn't seem to exist in the source mentioned in reference: the occurrence of the "CSS3 technology" appears with a dissimilar icon (see below). |
I would rather amend the guidelines to include "widely recognized de facto standards" before taking down any of the icons discussed here. But in these cases there is no argument about the icons being representative or widely accepted. The only argument is that they are not official, and that the guidelines preclude this. I don't think that's enough rationale to get rid of such core symbols. |
Of course, the arguments of @jamesmontemagno are perfectly valid (it is why I mentioned some representations which have become de facto common even if they have no such formal value). But the comments made by @sachinraja on what appears like a peculiar contradiction currently existing between the acceptance of certain icons and the wording of the guidelines are just the same valid. It seems there is a dilemma to be resolved. 🤷♂️ |
Ok, the guidelines say that to request an icon: Is of a popular brand:
I'm going to say that this is that third case. We are on the verge of accepting an icon based on eyeballing a chart of Google Trends that "looked similar" to other included icons #6368. And we voted favorably because it looked right to several of us. Still, an small amendment would make this clearer, something like "Some icons may be elegible for inclusion by maintainers for particular reasons other than the ones stated, as long as there is consensus" or something of that sort. Again, better to change the guidelines than to eject these icons. |
I have no problem with the popularity of these icons. I only have a problem with their sources, so I agree with @jorgeamadosoria, I think an amendment would help clarify this. |
I've added a pull request with tentative text to address this issue in the contributing guidelines. All changes welcome there. |
You bring up an interesting issue @sachinraja, and the discussion so far has been excellent. I just want to add three things:
|
I agree, this makes the most sense to me. Does everyone agree that we should proceed with #6428 then? |
It seems as though there is no official JavaScript icon, which makes sense as there is no official governing body for it. The current source:
simple-icons/_data/simple-icons.json
Lines 4555 to 4557 in 198c42d
This uses the source https://github.com/voodootikigod/logo.js, which is unofficial. I realize that it may be too late to remove this icon as I'm sure it is a very popular one, but I thought I'd open this for discussion anyway.
The text was updated successfully, but these errors were encountered: