Updating guidelines unofficial source #6428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeamadosoria
added
the
docs
There was a problem hiding this comment.
I think the current approach is not correct.
- First the bullet list forms a set of conditions, all of which have to be met in order for the icon to be accepted. The bullet you added is an or-condition with the bullet preceding it, which is confusing.
- This section should probably not cover how the logo should be chosen, none of the other bullets and the title doesn't indicate the section will talk about logos.
I think it makes more sense to add it in the "1. Identify Official Logos and Colors" section.
ericcornelissen
added
in discussion
changed taking this input into account |
mondeja
requested changes
Aug 30, 2021
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
sachinraja
reviewed
Aug 31, 2021
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
Co-authored-by: Sachin Raja <sachinraja2349@gmail.com>
reduced the logo description to "widely accepted" rather than "well known or widely accepted de facto standard"
|
Is this ready for merging now @ericcornelissen @sachinraja ? |
mondeja
requested changes
Sep 2, 2021
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
…b.com/jorgeamadosoria/simple-icons into updating-guidelines-unofficial-source
mondeja
previously requested changes
Sep 2, 2021
ericcornelissen
approved these changes
Sep 2, 2021
ericcornelissen
removed
the
in discussion
sachinraja
reviewed
Sep 2, 2021
Co-authored-by: Sachin Raja <sachinraja2349@gmail.com>
|
Thanks @mondeja and @sachinraja for the fixes. What do you think is pending yet? |
sachinraja
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6418
Adding a textual amendment to contribution guidelines to address de facto standard icons to be added to the library via consensus of maintainers.
The text in the change is merely a proposal to get the ball rolling, I don't mind changing it completely as long as the spirit of it remains.