Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bastyon icon #7752

Merged
merged 4 commits into from Sep 7, 2022
Merged

Add Bastyon icon #7752

merged 4 commits into from Sep 7, 2022

Conversation

andyoknen
Copy link
Contributor

@andyoknen andyoknen commented Sep 6, 2022

bastyon

Bastyon is a decentralized social network based on the blockchain.

Issue: closes #5395
Website:: https://bastyon.com
Similarweb rank: 49,533
Contributing: Yes

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Difference preview

Screenshot_2

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 6, 2022
@LitoMore
Copy link
Member

LitoMore commented Sep 6, 2022

CleanShot 2022-09-07 at 02 27 44@2x

@andyoknen There is some difference. You could try with --precision 4 when you compressing the source file. Our default precision is 3.

npm run svgo -- -p 4 icons/bastyon.svg

@andyoknen
Copy link
Contributor Author

andyoknen commented Sep 6, 2022

@andyoknen There is some difference. You could try with --precision 4 when you compressing the source file. Our default precision is 3.

npm run svgo -- -p 4 icons/bastyon.svg

This gives no results. I checked different levels up to 7 - the result is the same as level 3.

Could you explain what your picture means?

@LitoMore
Copy link
Member

LitoMore commented Sep 6, 2022

@andyoknen Not re-svgo your compressed file. You need to redo your steps, and compress the source file with precision 4.

@andyoknen
Copy link
Contributor Author

andyoknen commented Sep 6, 2022

@andyoknen Not re-svgo your compressed file. You need to redo your steps, and compress the source file with precision 4.

Yes, I figured it out - maybe I'm missing something - I've tried npm and online service

original

@LitoMore
Copy link
Member

LitoMore commented Sep 6, 2022

@andyoknen Those black parts are differences. We should make the compressed file perfect fit the source one.

For example this PR #7732. You can see a perfect fit picture there.

@andyoknen
Copy link
Contributor Author

@LitoMore I still don't understand how to get this difference - a file in this pool and a source file in the repository are the same file..

@LitoMore
Copy link
Member

LitoMore commented Sep 6, 2022

@andyoknen Here is how I check differences:

  1. Download the processed SVG file from the pull request
  2. Open the file with Inkscape (or other SVG editor)
  3. Drag the original file (the source one) to Inkscape
  4. Resize the original file to 24, and center it, bring it to top
  5. Change the fill color of the source one to white
  6. Then you will see the difference

@andyoknen
Copy link
Contributor Author

andyoknen commented Sep 6, 2022

@LitoMore I understood - I specified logo20.svg in the issue as an official file, but that was before I got into the requirements for adding an icon. This file is not the best option. I will deal with this issue and bring logo20.svg to the correct form

@andyoknen
Copy link
Contributor Author

@LitoMore Hi! I fixed the icons in the repository and the original issue. Based on them, I made a file in this pull request

@LitoMore
Copy link
Member

LitoMore commented Sep 7, 2022

CleanShot 2022-09-08 at 01 13 09@2x

@andyoknen Perfect fit! Thank you for your contributions!

@LitoMore LitoMore merged commit d338fbf into simple-icons:develop Sep 7, 2022
@LitoMore LitoMore mentioned this pull request Sep 8, 2022
3 tasks
@github-actions github-actions bot mentioned this pull request Sep 11, 2022
mondeja added a commit that referenced this pull request Sep 11, 2022
# New Icons

- Bastyon (#7752)
- Dapr (#7754)
- PocketBase (#7758)
- SecurityScorecard (#7739)
- StackBlitz (#7732)
- Uptime Kuma (#7759)
- XO (#7749)
@LitoMore LitoMore mentioned this pull request Sep 13, 2022
3 tasks
@LitoMore LitoMore mentioned this pull request Oct 1, 2022
3 tasks
@LitoMore LitoMore mentioned this pull request Oct 16, 2022
3 tasks
This was referenced Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Bastyon Icon
2 participants