Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Megaease icon #7283

Closed
wants to merge 8 commits into from
Closed

Add Megaease icon #7283

wants to merge 8 commits into from

Conversation

lidegang888
Copy link

@lidegang888 lidegang888 commented Mar 30, 2022

megaease

Issue: n/a
GitHub Stars: 5.1k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Why did you pick the hex value?

#2442BFis the theme color of the MegaEase company.

Did you manually vectorize the logo?

Yes!

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 30, 2022
Copy link
Contributor

@zrfisaac zrfisaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found 3 mistakes in your SVG file:

  • 01 : Your SVG file didn't have the title tag.
    <title>MegaEase</title>
  • 02 : Your SVG file shouldn't have this attribute.
    fill="#000"
  • 03 : Your SVG file isn’t vertically centered.

Here are your file "megaease.svg" fixed:
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>MegaEase</title><path d="m7.306 3.25-.025.058-2.65 6.307.008.023L0 20.75h5.434l1.72-4.393L8.8 20.75h5.434zm6.854 6.193 2.794-6.193L24 20.75h-5.539z"/></svg>

@elliotwutingfeng
Copy link
Contributor

svg: <svg width="421" height="308" viewBox="0 0 421 308" fill="none" xmlns="http://www.w3.org/2000/svg"><path fill-rule="evenodd" clip-rule="evenodd" d="M128.152.0l43.75 111.525-76.58 195.541H0L128.152.0z" fill="#fff" /><path fill-rule="evenodd" clip-rule="evenodd" d="M81.2246 111.691 128.151.0 249.676 307.066H154.354L81.2246 111.691z" fill="#fff" /><path fill-rule="evenodd" clip-rule="evenodd" d="M248.382 108.672 297.413.0 421 307.066H323.844L248.382 108.672z" fill="#fff" fill-opacity=".501543" /></svg> from https://megaease.com website source code.

@lidegang888 lidegang888 reopened this Mar 31, 2022
@lidegang888
Copy link
Author

I've found 3 mistakes in your SVG file:

  • 01 : Your SVG file didn't have the title tag.
    <title>MegaEase</title>
  • 02 : Your SVG file shouldn't have this attribute.
    fill="#000"
  • 03 : Your SVG file isn’t vertically centered.

Here are your file "megaease.svg" fixed: <svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>MegaEase</title><path d="m7.306 3.25-.025.058-2.65 6.307.008.023L0 20.75h5.434l1.72-4.393L8.8 20.75h5.434zm6.854 6.193 2.794-6.193L24 20.75h-5.539z"/></svg>

Thanks, I have replaced the correct SVG file.

@lidegang888
Copy link
Author

I've found 3 mistakes in your SVG file:

  • 01 : Your SVG file didn't have the title tag.
    <title>MegaEase</title>
  • 02 : Your SVG file shouldn't have this attribute.
    fill="#000"
  • 03 : Your SVG file isn’t vertically centered.

Here are your file "megaease.svg" fixed: <svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>MegaEase</title><path d="m7.306 3.25-.025.058-2.65 6.307.008.023L0 20.75h5.434l1.72-4.393L8.8 20.75h5.434zm6.854 6.193 2.794-6.193L24 20.75h-5.539z"/></svg>

I've found 3 mistakes in your SVG file:

  • 01 : Your SVG file didn't have the title tag.
    <title>MegaEase</title>
  • 02 : Your SVG file shouldn't have this attribute.
    fill="#000"
  • 03 : Your SVG file isn’t vertically centered.

Here are your file "megaease.svg" fixed: <svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>MegaEase</title><path d="m7.306 3.25-.025.058-2.65 6.307.008.023L0 20.75h5.434l1.72-4.393L8.8 20.75h5.434zm6.854 6.193 2.794-6.193L24 20.75h-5.539z"/></svg>

The pull request I submitted has not been merged so far. Could you tell me what should I do?

@sachinraja
Copy link
Contributor

Thanks for the help @zrfisaac and @elliotwutingfeng! This icon looks good, but it does not meet our requirements for popularity. The brand must have a single project with 5k GitHub stars, not a total across all its projects. And the Similarweb rank is lower than 500k.

@sachinraja sachinraja added the in discussion There is an ongoing discussion that should be finished before we can continue label Apr 24, 2022
@zrfisaac
Copy link
Contributor

I didn't know the rule about 5k GitHub stars. Thanks for the explanation.

@lidegang888
Copy link
Author

lidegang888 commented Mar 1, 2023

Hello, I hope this message finds you well.
I am writing to inquire about the possibility of adding the Megaease icon to your project. I wanted to introduce you to the Megaease, a reputable company with a highly-rated project on GitHub called easegress. This project has garnered over 5k stars and has been widely recognized for its quality and reliability.
Thank you for your consideration, and I look forward to hearing from you soon.

@elliotwutingfeng
Copy link
Contributor

easegress

Easegress meets the 5k stars requirement and they have an SVG logo. Feel free to open a PR for Easegress. Not sure about Megaease itself @sachinraja any thoughts?

@adamrusted
Copy link
Member

I would be happy to merge Easegress based on the GitHub stars - but unfortunately the Megaease website does not meet the criteria for inclusion. Unless another @simple-icons/maintainers wants to chip in - I'd say we'll have to close this PR I'm afraid.

@LitoMore
Copy link
Member

LitoMore commented Jul 9, 2023

It looks good to me. Some GitHub projects even don't have a domain for homepage.

@adamrusted
Copy link
Member

@LitoMore - so just to confirm, you'd be happy to add both MegaEase and Easegress to the project? If so, I'll review this icon shortly.

@LitoMore
Copy link
Member

LitoMore commented Jul 9, 2023

Yes, both look good to me. The Easegress is active, see https://github.com/megaease/easegress/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Amerged+-label%3Adependencies.

icons/megaease.svg Show resolved Hide resolved
@adamrusted adamrusted added changes requested and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Jul 9, 2023
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing visible differences between your PR version in black, and the SVG available on their homepage. Could you please regenerate this from source? 🙏

@lidegang888
Copy link
Author

so mean.

@LitoMore
Copy link
Member

LitoMore commented Aug 17, 2023

Hey @lidegang888, the shape you've submitted has been stretched. We can't accept a stretched trademark.

The expected size should be:

image

But yours:

image

So it has some differences in black color:

image

You may need to enable the lock to ensure the aspect ratio is correct when resizing.

BTW, here is how we review icons: #7752 (comment).

@adamrusted adamrusted added abandoned Pull requests that have been abandoned by the contributor and removed new icon Issues or pull requests for adding a new icon changes requested labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Pull requests that have been abandoned by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants