New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Megaease icon #7283
Add Megaease icon #7283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found 3 mistakes in your SVG file:
- 01 : Your SVG file didn't have the title tag.
<title>MegaEase</title>
- 02 : Your SVG file shouldn't have this attribute.
fill="#000"
- 03 : Your SVG file isn’t vertically centered.
Here are your file "megaease.svg" fixed:
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>MegaEase</title><path d="m7.306 3.25-.025.058-2.65 6.307.008.023L0 20.75h5.434l1.72-4.393L8.8 20.75h5.434zm6.854 6.193 2.794-6.193L24 20.75h-5.539z"/></svg>
svg: |
Thanks, I have replaced the correct SVG file. |
The pull request I submitted has not been merged so far. Could you tell me what should I do? |
Thanks for the help @zrfisaac and @elliotwutingfeng! This icon looks good, but it does not meet our requirements for popularity. The brand must have a single project with 5k GitHub stars, not a total across all its projects. And the Similarweb rank is lower than 500k. |
I didn't know the rule about 5k GitHub stars. Thanks for the explanation. |
Hello, I hope this message finds you well. |
Easegress meets the 5k stars requirement and they have an SVG logo. Feel free to open a PR for Easegress. Not sure about Megaease itself @sachinraja any thoughts? |
I would be happy to merge Easegress based on the GitHub stars - but unfortunately the Megaease website does not meet the criteria for inclusion. Unless another @simple-icons/maintainers wants to chip in - I'd say we'll have to close this PR I'm afraid. |
It looks good to me. Some GitHub projects even don't have a domain for homepage. |
@LitoMore - so just to confirm, you'd be happy to add both MegaEase and Easegress to the project? If so, I'll review this icon shortly. |
Yes, both look good to me. The Easegress is active, see https://github.com/megaease/easegress/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Amerged+-label%3Adependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing visible differences between your PR version in black, and the SVG available on their homepage. Could you please regenerate this from source? 🙏
so mean. |
Hey @lidegang888, the shape you've submitted has been stretched. We can't accept a stretched trademark. The expected size should be: But yours: So it has some differences in black color: You may need to enable the lock to ensure the aspect ratio is correct when resizing. BTW, here is how we review icons: #7752 (comment). |
Issue: n/a
GitHub Stars: 5.1k
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Why did you pick the hex value?
#2442BF
is the theme color of the MegaEase company.Did you manually vectorize the logo?
Yes!