Add Quizlet icon #10721
Open
Add Quizlet icon #10721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
new icon
|
Did you mean to open both #10720 and this PR? |
Sorry this is my first ever pull request on a open source project, opened both by accident. |
|
No worries! Looks like you figured it out :D I've edited your original comment to fix the checkboxes and link to the original issue. Would you also like to try making a preview image for the icon? See https://wasm.simpleicons.org/preview. |
uncenter
reviewed
Mar 27, 2024
|
Preview image looks good, nice job! I believe the issue with the SVG (which is making the check fail) is that you have an extra space before |
uncenter
reviewed
Mar 27, 2024
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
|
Thanks for the help :) |
adamrusted
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #10718.
Popularity metric: The Similarweb rank is 259 globally. See https://www.similarweb.com/website/quizlet.com/#overview.
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Name
As it appears on their website
Icon
Derived from the official svg icon from https://commons.wikimedia.org/wiki/File:Quizlet_Logo_2021.svg
Color
Extracted from original svg icon color
#4255FF