Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stylus Icon #10722

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

EricRisher
Copy link

@EricRisher EricRisher commented Mar 28, 2024

image

Issue: closes #10719

Popularity metric: The github has a currently 5026 stars and a upward trajectory. See
https://star-history.com/#openstyles/stylus&Date

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Name

As it appears on their website and uncenter's suggestion to add extension after because stylus icon is already taken.

Icon

Derived from the their official github svg icon and removed styling so that logo is monochromatic https://gist.github.com/pabli24/85c406ebfdb840cb0450e029b28948b8#file-stylus-logo-svg

Color

Extracted from original svg icon color

  • #285959

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 28, 2024
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to keep your PRs to only one icon at a time. Could you look to split Quizlet into it's own PR please @EricRisher?

_data/simple-icons.json Outdated Show resolved Hide resolved
@EricRisher
Copy link
Author

Please try to keep your PRs to only one icon at a time. Could you look to split Quizlet into it's own PR please @EricRisher?

Hey Adam I'm still really new to contributing to open source projects, could you please inform me on how to split the PRs?

@adamrusted
Copy link
Member

Sure - I'd just revert the addition of the Quizlet changes in this branch - that'd take us back to just having the one icon in this one!

@adamrusted
Copy link
Member

I've removed Quizlet, and had a go at doing something different with the paths. This one is a real pain to work with - so kudos for giving it a shot @EricRisher! Could another @simple-icons/pr-reviewers take a look at this now I've contributed?

@@ -0,0 +1 @@
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Stylus</title><path d="M24 10.688V13.5h-1.5v7.688c0 1.546-1.266 2.812-2.813 2.812H4.312C2.766 24 1.5 22.734 1.5 21.187V13.5H0v-2.813l1.5.001V2.813C1.5 1.266 2.766 0 4.312 0h15.375C21.234 0 22.5 1.266 22.5 2.813v7.875H24ZM4.969.938c-1.313 0-2.344 1.031-2.344 2.343v7.407s-.094.843-1.5.843v1.125c1.406 0 1.5.844 1.5.844v7.219c0 1.312 1.031 2.344 2.344 2.344h14.062c1.313 0 2.344-1.032 2.344-2.344V13.5s.094-.844 1.5-.844v-1.125c-1.406 0-1.5-.843-1.5-.843V3.281c0-1.312-1.031-2.343-2.344-2.343H4.969ZM20.375 13.5v7.219c0 .752-.591 1.344-1.344 1.344H4.969c-.753 0-1.344-.592-1.344-1.344v-7.147c.004-.061.001-.143-.013-.231-.012-.082-.077-.52-.483-.949a2.1008 2.1008 0 0 0-.348-.298c.142-.097.256-.2.348-.298.406-.429.471-.868.483-.949a.2912.2912 0 0 0 .006-.045.8768.8768 0 0 0 .007-.115V3.281c0-.752.591-1.343 1.344-1.343h14.062c.753 0 1.344.591 1.344 1.343v7.407l.007.114s.002.018.006.045c.012.081.077.52.483.949.092.098.206.201.348.298-.142.097-.256.2-.348.298-.406.429-.471.867-.483.949-.004.026-.006.044-.006.044s-.007.667-.007.115ZM12.844 2.953c-4.125 0-6.656 2.297-6.656 5.297 0 2.531 1.921 4.125 4.828 5.203 2.109.703 2.953 1.313 2.953 2.438 0 1.125-.938 1.875-2.766 1.875-1.687 0-3.375-.516-4.406-1.078L6 19.922c.984.562 2.953 1.125 4.969 1.125 4.781 0 7.031-2.531 7.031-5.438 0-2.484-1.406-4.125-4.5-5.25-2.297-.843-3.281-1.359-3.281-2.484 0-.891.89-1.687 2.578-1.687 1.687 0 2.953.515 3.609.843l.891-3.187c-1.031-.469-2.484-.891-4.453-.891Z"/></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the source, I think I would opt for the following treatment
image

Where did you see the current one @adamrusted?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created it myself based on the colour logo - the treatment you've shown above does not display well at the smaller sizes our project are generally used for - so I tried to counter that by just having the inlay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Stylus
3 participants