Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreshRSS icon #10860

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

10xLaCroixDrinker
Copy link
Contributor

@10xLaCroixDrinker 10xLaCroixDrinker commented Apr 26, 2024

FreshRSS simpleicons preview

Issue: closes #10698

Popularity metric: 8.4K stars

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Apr 26, 2024
@uncenter
Copy link
Member

I wonder if there is a way we can show the differences in shading of the original icon in a monochrome form. Maybe the lighter blue sections are outlined instead of solid?

@10xLaCroixDrinker
Copy link
Contributor Author

10xLaCroixDrinker commented Apr 27, 2024

Maybe the lighter blue sections are outlined instead of solid?

Done. Updated preview in description

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-04-27 at 20 10 22 (Inkscape)

I'm seeing differences with the circle in the center.

@10xLaCroixDrinker
Copy link
Contributor Author

I'm seeing differences with the circle in the center.

Should be all good now 👍🏻

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-04-27 at 21 31 17 (Inkscape)

Still seeing differences with the blue circle on my end.

@10xLaCroixDrinker
Copy link
Contributor Author

Still seeing differences with the blue circle on my end.

Okay now it should be all set

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-04-27 at 21 53 50 (Inkscape)

Shoot, still seeing differences! The differences around the center circle are small enough to not matter but the differences around the outer rings needs to be fixed.

@uncenter
Copy link
Member

This may be an issue with the precision when you are optimizing it FYI. You can try a precision of 3 or 4 to see if that helps.

@10xLaCroixDrinker
Copy link
Contributor Author

@uncenter I redid the whole thing and I used a precision of 3 when optimizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: FreshRSS
2 participants