Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase similarity threshold on potential duplicates workflow #10870

Merged
merged 1 commit into from Apr 30, 2024

Conversation

uncenter
Copy link
Member

See title. I've been seeing many many false positives at exactly 70%, bumping up to 80% should still catch some actual duplicates while ignoring the obvious false positives.

@simple-icons simple-icons bot added the meta Issues or pull requests regarding the project or repository itself label Apr 28, 2024
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about 75?

@uncenter
Copy link
Member Author

What about 75?

We could try that I guess. I looked back through a bunch of issues that had been marked as duplicates at some point or another and 80% looked to be the right threshold (if not higher!).

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's try with 80 👍🏼

@mondeja mondeja merged commit e2a0e28 into develop Apr 30, 2024
13 checks passed
@mondeja mondeja deleted the uncenter-patch-1 branch April 30, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants