Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add n8n icon #10909

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

CodeShakingSheep
Copy link
Contributor

@CodeShakingSheep CodeShakingSheep commented May 6, 2024

image

Issue: closes #7993

Popularity metric:

The Similarwebrank is 60,987. See https://www.similarweb.com/fr/website/n8n.io

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I forgot where I downloaded the original svg icon (had it on my computer for quite a while). I just combined the paths and applied the transformations to them. Then optimized it.

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label May 6, 2024
icons/n8n.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I'm seeing a bunch of differences as illustrated by the screenshot above. Are you using the logo from their website's header? Also I'd like to note that you said " I just combined the paths and applied the transformations to them." - there are no paths to combine for this logo!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They also have a press kit from which you can source the icon: https://n8n.io/press/. n8n-symbol-only.svg would be the file to grab.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, right. As I wrote I had this other n8n icon svg on my computer for a while (and don't know anymore from where I downloaded it). With the official svg icon you linked, I have a problem with removing fill-rule="evenodd" clip-rule="evenodd", see screenshot. The problem is that 2 of the small circles get filled. I don't know how to solve that. Do you have any idea?

image

Copy link
Member

@uncenter uncenter May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not sure. @PeterShaggyNoble I recall you helped me before with an icon that had fill-rule="evenodd", any idea how can we get rid of it here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the exact science with this - but I've always been able to 'split' the path in my editor, move the circle shapes up/down (changes per program) and then re-do the merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I managed to solve this by breaking apart the path (in Inkscape), then creating 4 little circles in the size of the 4 small paths and then took the difference between the big path and the 4 little circles respectively. Is it good now?

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/n8n.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the exact science with this - but I've always been able to 'split' the path in my editor, move the circle shapes up/down (changes per program) and then re-do the merging.

CodeShakingSheep and others added 2 commits May 19, 2024 13:51
Update source

Co-authored-by: Adam Rusted <adamrusted@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

n8n
3 participants