Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis CI deploy step for release tags #1558

Merged
merged 10 commits into from Aug 15, 2019
Merged

Add Travis CI deploy step for release tags #1558

merged 10 commits into from Aug 15, 2019

Conversation

ericcornelissen
Copy link
Contributor

@ericcornelissen ericcornelissen commented Jul 25, 2019

Issue: #747, #1427

Description

This adds a new step to the Travis CI deploy stage that will tag the current commit on master and push the commit to GitHub so that it will appear in the repository's releases page.

This automatically includes the tags in git as well, making it easier to find releases straight from the source code. This is also the way Packagist will version the package, which is the original reason for adding this.

Todo

  • Configure a git user to author the tag.
  • It should find the version number from ./package.json.
  • Further testing

TODO: should find the version number from ./package.json
@ericcornelissen ericcornelissen added the meta Issues or pull requests regarding the project or repository itself label Jul 25, 2019
@ericcornelissen
Copy link
Contributor Author

ericcornelissen commented Jul 26, 2019

After further testing a managed to get an automatic deploy of a git tag (1.12.0, based on package.json) working. You can view the build here and the config here (to compare it with the config in this Pull Request) below is a screenshot of the tag it created on GitHub (I removed the tag and release after I took the screenshot).

test

@ericcornelissen ericcornelissen marked this pull request as ready for review July 26, 2019 16:36
@birjj birjj merged commit 96a8ab3 into simple-icons:develop Aug 15, 2019
@birjj
Copy link
Contributor

birjj commented Aug 15, 2019

👍 Thanks for taking care of this @ericcornelissen! It's something we've been missing for a long while, so it's great to finally get it out.

Also sorry for the very late review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants